Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add updated_at and created_at attributes for FeedbackDataset in Argilla #3709

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

alvarobartt
Copy link
Member

@alvarobartt alvarobartt commented Sep 5, 2023

Description

This PR adds the args created_at and updated_at to the RemoteFeedbackDataset and FilteredRemoteFeedbackDataset classes, as well as the properties created_at and updated_at which are set during the init via a protected attribute and not modified while the class is still instantiated.

This is useful towards the python -m argilla datasets list command of the CLI, as those were the only fields that were present for the TextClassification, TokenClassification, and Text2Text datasets, while those were missing for the FeedbackDataset, so the generated table had a mismatch between the available information for ones and the others.

Besides that, the datasets list command has also been updated so as to use those properties and display the same information as in the other datasets.

Closes #3664

Side-note

We've decided not to add the request to GET /api/v1/datasets/{dataset_id} in the updated_at property, even though it may be needed in the future, as the last update date may be one but we may have applied changes later on, while updated_at will still show the one fulfilled during the class insntatiation.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Add integration tests for the RemoteFeedbackDataset attributes/properties
  • Add integration tests for the FilteredRemoteFeedbackDataset attributes/properties

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@alvarobartt alvarobartt added this to the v1.16.0 milestone Sep 5, 2023
@alvarobartt alvarobartt self-assigned this Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3709-ki24f765kq-no.a.run.app

@alvarobartt alvarobartt merged commit 4aafedb into develop Sep 5, 2023
17 checks passed
@alvarobartt alvarobartt deleted the feat/add-date-attributes branch September 5, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add both created_at and updated_at attributes to RemoteFeedbackDataset
2 participants