-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle PermissionError
in CLI
#3717
Conversation
PermissionError
in CLIPermissionError
in CLI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The new handler_permission_error
looks really nice, and I also like the rename to ArgillaTyper
, thanks
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3717-ki24f765kq-no.a.run.app |
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
Description
This PR adds a way to handle the
PermissionError
s that could be raised when executing a command with a logged in user that doesn't have the required permissions because of his role. In addition, the moduleargilla.tasks.async_typer
has been renamed toargilla.tasks.typer_ext
(Typer extension) and theAsyncTyper
class has been renamed toArgillaTyper
.Type of change
How Has This Been Tested
In a local development environment:
Checklist
CHANGELOG.md
file (See https://keepachangelog.com/)