Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 fix console warning due to missing props #3725

Merged

Conversation

keithCuniah
Copy link
Contributor

Since the guidelines of a dataset could be empty, when going on the settings page of a dataset there is some missing props warning in the console of the browser.

image

Type of change

  • Bug fix

How Has This Been Tested

  • settings page of all dataset (feedback task and old tasks)

@keithCuniah keithCuniah added area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: bug Indicates an unexpected problem or unintended behavior labels Sep 7, 2023
@keithCuniah keithCuniah added this to the v1.16.0 milestone Sep 7, 2023
@keithCuniah keithCuniah marked this pull request as ready for review September 7, 2023 09:04
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3725-ki24f765kq-no.a.run.app

@damianpumar damianpumar merged commit 116878d into develop Sep 7, 2023
11 checks passed
@damianpumar damianpumar deleted the fix/dataset_without_guidelines_show_error_in_console branch September 7, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants