Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: resolved failing test with correct imports #3728

Merged
merged 21 commits into from
Sep 7, 2023
Merged

tests: resolved failing test with correct imports #3728

merged 21 commits into from
Sep 7, 2023

Conversation

davidberenstein1957
Copy link
Member

Argilla Community Growers

Thanks for your contribution! As part of our Community Growers initiative 🌱, we're donating Justdiggit bunds in your name to reforest sub-Saharan Africa. To claim your Community Growers certificate, please contact David Berenstein in our Slack community or fill in this form https://tally.so/r/n9XrxK once your PR has been merged.

Pull Request Templates

Please go the the Preview tab and select the appropriate sub-template:

Generic Pull Request Template

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes #<issue_number>

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test A
  • Test B

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

davidberenstein1957 and others added 20 commits August 30, 2023 14:59
@davidberenstein1957
chore: added support for new openai models for old datasets argilla
874b190 
chore: added self.__legacy routing to correct usage paramce
chore: replaced json-file by bytestring
chore: added TrainingTaskForChatCompletion
@davidberenstein1957
docs: updated config tabs
2ba4398 
chore: updated default params
docs: updated support table overview
@davidberenstein1957
docs: updated content update_config
f6dabcb
@davidberenstein1957
docs: added initial outline for the background of chat completion
17d8faa
@davidberenstein1957
chore: rename userid and chatid to user and chat
0b32142
@davidberenstein1957
chore: updated require_version
c55c292
@davidberenstein1957 @gabrielmbmb
Update src/argilla/client/feedback/training/schemas.py
834b3e5 
Co-authored-by: Gabriel Martín Blázquez <[email protected]>
@davidberenstein1957
docs: added docs on Training for Chat Completion
8edec5e
@davidberenstein1957
chore: updated changelog.md
be65ca5
@davidberenstein1957
chore: added tests for OpenAI training
921e6e6
@davidberenstein1957
tests: corrected wrong tests
52e5eed
@davidberenstein1957
Merge branch 'develop' into feat/3615-feature-update-openai-fine-tuni…
1cc6d14 
…ng-with-gpt-35-turbo-0613-to-argillatrainer
@davidberenstein1957
chore: resolved comments Gabriel
23fc147
@davidberenstein1957
tests: added mocked openai import
a876d1d
@davidberenstein1957 @alvarobartt
Apply suggestions from code review
af82703 
Co-authored-by: Alvaro Bartolome <[email protected]>
@davidberenstein1957
chore: renamed
45f7c43
@davidberenstein1957
chore: added model warning when using defaults
5803175
@davidberenstein1957 @alvarobartt
Update docs/_source/guides/llms/practical_guides/fine_tune.md
de9e336 
Co-authored-by: Alvaro Bartolome <[email protected]>
@davidberenstein1957
chore: added some type hints
cb63c04
@davidberenstein1957
tests: resolved failing test with correct imports
d648232
@alvarobartt
Copy link
Member

Hi @davidberenstein1957 I think you forgot to git pull origin develop before creating the new branch and now the commits seem a bit off, feel free to force-push fix/failing-tests-openai once develop is merged into it

@davidberenstein1957
Copy link
Member Author

davidberenstein1957 commented Sep 7, 2023 •
edited
Loading

Yes exactly. I forgot to push my final changes before.

@davidberenstein1957
Merge branch 'develop' into fix/failing-tests-openai
e0f5296 
# Conflicts:
#	src/argilla/training/openai.py
#	tests/integration/client/feedback/training/test_openai.py
@davidberenstein1957 davidberenstein1957 merged commit 6610628 into develop Sep 7, 2023
13 checks passed
@davidberenstein1957 davidberenstein1957 deleted the fix/failing-tests-openai branch September 7, 2023 10:25
alvarobartt
alvarobartt reviewed Sep 7, 2023
View reviewed changes
tests/integration/client/feedback/training/test_openai.py
@@ -14,8 +14,8 @@

import re

import argilla as rg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in the former PR we shouldn't use import argilla as rg, but the actual imports e.g. from argilla.client.feedback.dataset import FeedbackDataset, and so on. As import argilla as rg is designed for users, internally we should point to the actual module, not to its reference.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed mimicking the user flow would be best but will keep this in mind for the following PRs

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3728-ki24f765kq-no.a.run.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarobartt alvarobartt alvarobartt left review comments

@gabrielmbmb gabrielmbmb Awaiting requested review from gabrielmbmb

Assignees

@davidberenstein1957 davidberenstein1957

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidberenstein1957 @alvarobartt