-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: follow-up fixes for detached pydantic.BaseModel
schemas
#3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
To avoid using the schema defined in the SDK Co-authored-by: Paco Aranda <[email protected]>
…r-schema-refactor
Tested with a matrix from v1.8.0, when the `push_to_huggingface` method was initially introduced, until v1.17.0
frascuchon
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains some bug-fixes and improvements as a follow up for #3784.
FeedbackDataset
from the Hugging Face Hub fails if exported with an outdated version as it still contained the ID for some columnsadd_records
over an existingFeedbackDataset
in Argilla i.e. aRemoteFeedbackDataset
fails because the_fields_schema
is not definedFeedbackDatasetBase
, but move local validation toFeedbackDataset
generate_pydantic_schema
functionfrom_huggingface
to be backwards compatible with previously uploadedFeedbackDataset
datasets to the Hugging Face Hub (from Argilla v1.8.0)Kudos @frascuchon for detecting and reporting the bugs tackled in this PR!
Type of change
How Has This Been Tested
rg.FeedbackDataset.from_huggingface("argilla/oasst_response_quality", split="train")
DatasetConfig.from_yaml
works as intendedFeedbackDataset
in Argilla works as expectedChecklist