Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for update records from SDK #3946

Commits on Oct 13, 2023

  1. fix: Using utcnow datetime

    frascuchon committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    1ce3feb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    86a3ea1 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. Merge branch 'feature/support-for-metadata-filtering-and-sorting' int…

    …o feat/support-for-update-records-from-SDK
    frascuchon committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    ce580db View commit details
    Browse the repository at this point in the history
  2. feat: Define update_recordsfor base feeedback dataset class

    Also, this class defines an generic type `R` for records.
    frascuchon committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    83bac6f View commit details
    Browse the repository at this point in the history
  3. refactor: Implement update_records method for local datasets

    The implementation will show a warning with an explicit message
    frascuchon committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    b10ea26 View commit details
    Browse the repository at this point in the history
  4. feat: Implement update_records method based on record.update

    Also, the question (id -> name) and question (name -> id) maps are computed from the original dataset
    frascuchon committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    bbd4236 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bcdbe9c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1a464f3 View commit details
    Browse the repository at this point in the history
  7. feat: record.update support record level update

    Records can be updated by assigning content and then call the `record.update` method.
    
    Suggestions are still supported, so users can update a record by passing the suggestions. But a more general way should be:
    
    ```python
    record.metadata.update({"new": "metadata"})
    record.suggestions = (Suggestion....)
    
    record.update()
    ```
    frascuchon committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    875f88a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1daff38 View commit details
    Browse the repository at this point in the history
  9. refactor: Support updating record suggestions through `update_records…

    …` workflow
    
    Record suggestions can be modified locally to prepare changes and then call the `ds.updated_records` with modified suggestions. The `record.update` still support suggestions
    
    ```python
    records = ds.records[:10]
    
    for record in records:
       record.suggestions = [SuggestionSchema(...)]
       record.metadata.update({"new": "metadata"})
    
    # Apply all local changes to remote records
    ds.update_records(records)
    
    ```
    frascuchon committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    8e24a36 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b28c45f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c42b963 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    2a94c0e View commit details
    Browse the repository at this point in the history
  13. refactor: Control record suggestions updates from `update(suggestions…

    …=...) and `record.update()`
    
    The suggestions will be filtered before update them if suggestions where provided in the `record.update` method. Otherwise, the record suggestions will be sent as new suggestions
    frascuchon committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    ab77ecb View commit details
    Browse the repository at this point in the history
  14. refactor: Define the workspace instance creation method private for b…

    …etter integration with unit tests
    
    (A code review must be taken in order to not modify a class because the tests)
    frascuchon committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    4b0ccbd View commit details
    Browse the repository at this point in the history
  15. fix: Indentation return

    frascuchon committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    256f797 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    547b641 View commit details
    Browse the repository at this point in the history
  17. chore: Adapt imports

    frascuchon committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    5d416d7 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    a85279a View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    2787be3 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    99e5d00 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    db1f466 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2023

  1. Configuration menu
    Copy the full SHA
    f219d7b View commit details
    Browse the repository at this point in the history
  2. Merge branch 'feat/support-for-update-records-from-SDK' of github.com…

    …:argilla-io/argilla into feat/support-for-update-records-from-SDK
    frascuchon committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    04c3829 View commit details
    Browse the repository at this point in the history
  3. chore: Update changelog

    frascuchon committed Oct 15, 2023
    Configuration menu
    Copy the full SHA
    02b5c29 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Merge branch 'feature/support-for-metadata-filtering-and-sorting' int…

    …o feat/support-for-update-records-from-SDK
    frascuchon committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    7537bd7 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'feature/support-for-metadata-filtering-and-sorting' int…

    …o feat/support-for-update-records-from-SDK
    frascuchon committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    15d36df View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2e74cd0 View commit details
    Browse the repository at this point in the history
  4. Apply suggestions from code review

    Co-authored-by: Alvaro Bartolome <[email protected]>
    frascuchon and alvarobartt authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    c24c65e View commit details
    Browse the repository at this point in the history