feat: add new filter support for search records endpoint #4327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
…dd-new-filter-support-for-search-records-endpoint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/responses-and-suggestion-filter #4327 +/- ##
===========================================================================
+ Coverage 65.69% 65.82% +0.13%
===========================================================================
Files 330 330
Lines 19013 19022 +9
===========================================================================
+ Hits 12490 12521 +31
+ Misses 6523 6501 -22 ☔ View full report in Codecov by Sentry. |
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4327-ki24f765kq-no.a.run.app |
jfcalvo
requested changes
Nov 28, 2023
…arse query sections there
for more information, see https://pre-commit.ci
…int' of github.com:argilla-io/argilla into feature/add-new-filter-support-for-search-records-endpoint
jfcalvo
approved these changes
Nov 28, 2023
jfcalvo
merged commit d70a8e9
into
feature/responses-and-suggestion-filter
15 of 16 checks passed
jfcalvo
deleted the
feature/add-new-filter-support-for-search-records-endpoint
branch
leiyre
pushed a commit
that referenced
this pull request
Nov 28, 2023
…argilla-io/argilla into feature/responses-and-suggestion-filter * 'feature/responses-and-suggestion-filter' of github.com:argilla-io/argilla: feat: add new filter support for search records endpoint (#4327)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates the
POST /api/v1/dataset/:dataset_id/records/searchwith search engine to supportfilterandsortbody attributes.Also, the base filter classes are decorated as
dataclassin order to provide an easy way to compare args in tests (dataclassprovide automaticeqmethod)Refs #4227
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
Checklist
CHANGELOG.mdfile (See https://keepachangelog.com/)