Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/responses suggestions filter fine tune #4356

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Fix/responses suggestions filter fine tune #4356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
710c650
✨ Bold when option was selected
damianpumar Nov 29, 2023
54c0eb0
✨ Disabled next page when the user is in last possible page.
damianpumar Nov 29, 2023
bddbe03
✨ Add tooltip to SortCategoriesList.vue and
damianpumar Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion frontend/components/feedback-task/footer/Pagination.component.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
class="pagination__button"
ref="nextButton"
@click="onClickNext"
:disabled="isLastPage"
:title="
$platform.isMac
? $t('shortcuts.pagination.go_to_next_record_mac')
Expand Down Expand Up @@ -52,10 +53,13 @@ export default {
},
},
computed: {
// TODO: Move to PageCriteria to support those computed
isFirstPage() {
return this.currentPage === 1;
},
// TODO: Do PageCriteria to support this
isLastPage() {
return this.currentPage === this.items;
},
totalPages() {
return Math.ceil(this.items / this.itemsPerPage);
},
Expand Down
4 changes: 4 additions & 0 deletions frontend/components/feedback-task/header/filters/CategoriesSelector.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
<BaseButton
@on-click="selectCategory(category)"
class="category__item"
:class="category.isAnswered ? 'category__item--selected' : null"
:disabled="!category.canFilter"
>
<span v-if="!!category.title" v-text="category.title" />
Expand Down Expand Up @@ -77,6 +78,9 @@ export default {
justify-content: space-between;
border-radius: $border-radius;
font-weight: 400;
&--selected {
font-weight: 600;
}
span {
overflow: hidden;
text-overflow: ellipsis;
Expand Down
1 change: 1 addition & 0 deletions frontend/components/feedback-task/header/sort-filter/SortCategoriesList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
<li
v-for="category in getCategoriesByGroup(group)"
:key="category.name"
:title="category.tooltip"
>
<BaseButton
:disabled="!category.canSort"
Expand Down
8 changes: 8 additions & 0 deletions frontend/v1/domain/entities/sort/SortList.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ abstract class Sort {
get canSort(): boolean {
return true;
}

get tooltip() {
return this.title;
}
}

class MetadataSort extends Sort {
Expand Down Expand Up @@ -66,6 +70,10 @@ class SuggestionScoreSort extends Sort {
get title() {
return this.question.name;
}

get tooltip() {
return this.question.title;
}
}

class RecordSort extends Sort {
Expand Down