-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: relax pandas constraint version to allow for >2.0 #4600
Merged
frascuchon
merged 8 commits into
develop
from
feat/4599-why-pandas-=100200-dependency-is-used
Feb 27, 2024
Merged
feat: relax pandas constraint version to allow for >2.0 #4600
frascuchon
merged 8 commits into
develop
from
feat/4599-why-pandas-=100200-dependency-is-used
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
This PR changes 0-9 lines, ignoring generated files.
area: python sdk
Indicates that an issue or pull request is related to the Python SDK
language: python
Pull requests or issues that update Python code
team: backend
Indicates that the issue or pull request is owned by the backend team
type: improvement
Indicates updates or improvements on existing features
labels
Feb 22, 2024
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4600-ki24f765kq-no.a.run.app |
davidberenstein1957
changed the title
feat: bump pandas version to 2.0
feat: relax pandas constraint version to allow for >2.0
Feb 22, 2024
16 tasks
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
and removed
size:XS
This PR changes 0-9 lines, ignoring generated files.
labels
Feb 23, 2024
frascuchon
added a commit
that referenced
this pull request
Feb 26, 2024
# Description Check if problems found at PR #4600 are associated to latests changes on `argilla-server` repository. **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (change restructuring the codebase without changing functionality) - [ ] Improvement (change adding some improvement to an existing functionality) - [ ] Documentation update **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [ ] Test A - [ ] Test B **Checklist** - [ ] I added relevant documentation - [ ] follows the style guidelines of this project - [ ] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Paco Aranda <[email protected]> Co-authored-by: Damián Pumar <[email protected]> Co-authored-by: leire <[email protected]>
dosubot
bot
added
size:XS
This PR changes 0-9 lines, ignoring generated files.
and removed
size:S
This PR changes 10-29 lines, ignoring generated files.
labels
Feb 27, 2024
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
and removed
size:XS
This PR changes 0-9 lines, ignoring generated files.
labels
Feb 27, 2024
13 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4600 +/- ##
============================================
+ Coverage 45.28% 89.04% +43.76%
============================================
Files 190 190
Lines 11673 11667 -6
============================================
+ Hits 5286 10389 +5103
+ Misses 6387 1278 -5109 ☔ View full report in Codecov by Sentry. |
davidberenstein1957
requested review from
frascuchon,
jfcalvo and
gabrielmbmb
February 27, 2024 13:24
frascuchon
approved these changes
Feb 27, 2024
frascuchon
deleted the
feat/4599-why-pandas-=100200-dependency-is-used
branch
February 27, 2024 15:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: python sdk
Indicates that an issue or pull request is related to the Python SDK
language: python
Pull requests or issues that update Python code
lgtm
This PR has been approved by a maintainer
size:S
This PR changes 10-29 lines, ignoring generated files.
team: backend
Indicates that the issue or pull request is owned by the backend team
type: improvement
Indicates updates or improvements on existing features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems our usage of Pandas does not require any change w.r.t. upgrading to 2.0.
Closes #4599
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
N.A.
Checklist
CHANGELOG.md
file (See https://keepachangelog.com/)