-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: Ranking value from suggestions are not properly converted from HF datasets #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Base automatically changed from
bugfix/format-suggestions-for-ranking-values
to
develop
March 6, 2024 11:33
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
area: python sdk
Indicates that an issue or pull request is related to the Python SDK
severity: minor
Indicates that the issue isn't urgent or blocking
team: backend
Indicates that the issue or pull request is owned by the backend team
type: bug
Indicates an unexpected problem or unintended behavior
labels
Mar 6, 2024
frascuchon
changed the title
bugfix: Ranking value lists for suggestions are parsed as a single dict
bugfix: Ranking value from suggestions are not properly converted from HF datasets
Mar 6, 2024
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4629-ki24f765kq-no.a.run.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4629 +/- ##
============================================
+ Coverage 45.23% 89.03% +43.80%
============================================
Files 190 190
Lines 11664 11667 +3
============================================
+ Hits 5276 10388 +5112
+ Misses 6388 1279 -5109 ☔ View full report in Codecov by Sentry. |
alvarobartt
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: python sdk
Indicates that an issue or pull request is related to the Python SDK
lgtm
This PR has been approved by a maintainer
severity: minor
Indicates that the issue isn't urgent or blocking
size:S
This PR changes 10-29 lines, ignoring generated files.
team: backend
Indicates that the issue or pull request is owned by the backend team
type: bug
Indicates an unexpected problem or unintended behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the custom conversion for suggestions with ranking value from HF datasets. Otherwise, ranking values won't be properly created when reading from a HF dataset:
instead of :
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)Tested locally
Checklist
CHANGELOG.md
file (See https://keepachangelog.com/)