Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: question.to_local returns description as None though it exists #4632

Conversation

frascuchon
Copy link
Member

Description

This PR maps the missing description attribute for questions from API response payloads.

Closes #4523

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

Tested locally

  • Test A
  • Test B

Checklist

  • I followed the style guidelines of this project
  • I did a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. area: tests Indicates that an issue or pull request is related to the tests language: python Pull requests or issues that update Python code severity: minor Indicates that the issue isn't urgent or blocking team: backend Indicates that the issue or pull request is owned by the backend team type: bug Indicates an unexpected problem or unintended behavior labels Mar 6, 2024
@frascuchon frascuchon changed the title bugfix: pythondeployment to local returns description as none though it exists bugfix: to_local returns description as None though it exists Mar 6, 2024
@frascuchon frascuchon changed the title bugfix: to_local returns description as None though it exists bugfix: question.to_local returns description as None though it exists Mar 6, 2024
@dosubot dosubot bot added this to the v.1.26.0 milestone Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4632-ki24f765kq-no.a.run.app

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.03%. Comparing base (9459e8f) to head (37b8ad3).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #4632       +/-   ##
============================================
+ Coverage    45.22%   89.03%   +43.81%     
============================================
  Files          190      190               
  Lines        11667    11667               
============================================
+ Hits          5276    10388     +5112     
+ Misses        6391     1279     -5112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 6, 2024
@frascuchon frascuchon merged commit 8bf9aec into develop Mar 7, 2024
16 checks passed
@frascuchon frascuchon deleted the 4523-bug-pythondeployment-to_local-returns-description-as-none-though-it-exists branch March 7, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tests Indicates that an issue or pull request is related to the tests language: python Pull requests or issues that update Python code lgtm This PR has been approved by a maintainer severity: minor Indicates that the issue isn't urgent or blocking size:S This PR changes 10-29 lines, ignoring generated files. team: backend Indicates that the issue or pull request is owned by the backend team type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG-python/deployment] to_local() returns description as None though it exists
2 participants