-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken search url #4633
fix: broken search url #4633
Conversation
It seems to be due to changes in the Enum specification in 3.11. I found that it works correctly in 3.10. |
Thanks for contributing, @katsuya We may have other places where this kind of error arises. I would love to know how did you find it. |
@frascuchon I discovered this issue while running autoprompt. Specifically, an error occurs at https://github.com/Eladlev/AutoPrompt/blob/7f373f219aa360cd2de38c6aa700c1dff282d7de/estimator/estimator_argilla.py#L106-L111. This section of the code checks if all records have been annotated. |
I checked the source code to see if this issue still occurs, and it seems to have been fixed in #4672. Are you still experiencing bugs even after applying this patch? |
Thanks for all this info @katsuya. |
Not really, I refreshed your PR with the latest changes from develop branch and it looks is already fixed. I will close this PR, since same changes are already in develop. |
Description
This PR fixes an issue where an invalid URL was generated due to passing an enum itself instead of its value to a template. Below are the URLs before and after the change:
/api/datasets/dataset__07_03_2024_15_06_50/TaskType.text_classification:search
/api/datasets/dataset__07_03_2024_15_06_50/TextClassification:search
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)Checklist
CHANGELOG.md
file (See https://keepachangelog.com/)