Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: "cannot import name 'formatargspec' from 'inspect'" with Python 3.11 #4693

Merged
merged 6 commits into from
May 6, 2024
Merged

Fix: "cannot import name 'formatargspec' from 'inspect'" with Python 3.11 #4693

merged 6 commits into from
May 6, 2024

Conversation

walter-hernandez
Copy link
Contributor

@walter-hernandez walter-hernandez commented Apr 2, 2024 •
edited
Loading

Description

The issue is: "ImportError: cannot import name 'formatargspec' from 'inspect'" with wrapt library that happens for Python 3.11. More details: GrahamDumpleton/wrapt#196

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Use current tests of Argilla

Checklist

  • I followed the style guidelines of this project
  • I did a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@walter-hernandez
Fixes issue of using wrapt 1.13 with Python 3.11
155f520 
The issue is: "ImportError: cannot import name 'formatargspec' from 'inspect'". More details: GrahamDumpleton/wrapt#196
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. area: python sdk Indicates that an issue or pull request is related to the Python SDK language: python Pull requests or issues that update Python code severity: major Indicates that the issue is blocking for users or needs to be addressed soon team: backend Indicates that the issue or pull request is owned by the backend team type: bug Indicates an unexpected problem or unintended behavior labels Apr 2, 2024
@walter-hernandez walter-hernandez changed the title Fixes issue of using wrapt 1.13 with Python 3.11 Fix: "cannot import name 'formatargspec' from 'inspect'" with Python 3.11 Apr 2, 2024
@frascuchon frascuchon merged commit dacb013 into argilla-io:develop May 6, 2024
13 of 14 checks passed
sdiazlor added a commit that referenced this pull request May 16, 2024
@sdiazlor
Revert "Fix: "cannot import name 'formatargspec' from 'inspect'" with…
66ecafa 
… Python 3.11 (#4693)"

This reverts commit dacb013.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frascuchon frascuchon frascuchon approved these changes

Assignees
No one assigned
Labels
area: python sdk Indicates that an issue or pull request is related to the Python SDK language: python Pull requests or issues that update Python code severity: major Indicates that the issue is blocking for users or needs to be addressed soon size:XS This PR changes 0-9 lines, ignoring generated files. team: backend Indicates that the issue or pull request is owned by the backend team type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@walter-hernandez @frascuchon