Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Improve performance #4702

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Conversation

damianpumar
Copy link
Contributor

@damianpumar damianpumar commented Apr 4, 2024

After trying this PR argilla-io/argilla-server#85, I have improved the performance for Single/Multi/Span questions.

The maximum supported value of options to guarantee good performance is 1000.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 4, 2024
@dosubot dosubot bot added area: ui Indicates that an issue or pull request is related to the User Interface (UI) language: javascript Pull requests or issues that update Javascript code severity: minor Indicates that the issue isn't urgent or blocking team: frontend Indicates that the issue or pull request is owned by the frontend team type: improvement Indicates updates or improvements on existing features labels Apr 4, 2024
@damianpumar damianpumar requested a review from jfcalvo April 4, 2024 11:16
Copy link

github-actions bot commented Apr 4, 2024

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4702-ki24f765kq-no.a.run.app

Copy link
Member

@leiyre leiyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 4, 2024
@jfcalvo
Copy link
Member

jfcalvo commented Apr 4, 2024

@damianpumar can you explain a little bit how is the performance improved? I don't understand the improvement seeing the code. Thanks.

@damianpumar damianpumar merged commit 42d07d0 into develop Apr 15, 2024
13 checks passed
@damianpumar damianpumar deleted the feat/improve-performance-disabling-css branch April 15, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) language: javascript Pull requests or issues that update Javascript code lgtm This PR has been approved by a maintainer severity: minor Indicates that the issue isn't urgent or blocking size:XS This PR changes 0-9 lines, ignoring generated files. team: frontend Indicates that the issue or pull request is owned by the frontend team type: improvement Indicates updates or improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants