Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(import): remove non-existent server module #4874

Merged
merged 3 commits into from
May 24, 2024

Conversation

frascuchon
Copy link
Member

Description

This PR remove the non-existent "server" module from __init__ definitions so users can import everything without errors:

from argilla import *

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test A
  • Test B

Checklist

  • I followed the style guidelines of this project
  • I did a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon added this to the v1.28.0 milestone May 24, 2024
@frascuchon frascuchon self-assigned this May 24, 2024
@frascuchon frascuchon merged commit b228f43 into develop May 24, 2024
5 checks passed
@frascuchon frascuchon deleted the bugfix/remove-failed-import branch May 24, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants