Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove API v1 workspaces exception captures #4897

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented May 28, 2024

Description

This PR remove all exception capture blocks for API v1 workspaces handler.

Refs #4871

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Improving and passing existent tests.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo requested a review from frascuchon May 28, 2024 14:14
Base automatically changed from refactor/remove-api-v1-suggestions-exceptions to refactor/improve-api-v1-error-handling May 30, 2024 12:08
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.93%. Comparing base (0299c2a) to head (667280b).

Additional details and impacted files
@@                            Coverage Diff                             @@
##           refactor/improve-api-v1-error-handling    #4897      +/-   ##
==========================================================================
- Coverage                                   90.94%   90.93%   -0.01%     
==========================================================================
  Files                                         206      206              
  Lines                                        9989     9982       -7     
==========================================================================
- Hits                                         9084     9077       -7     
  Misses                                        905      905              
Flag Coverage Δ
argilla-server 90.93% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfcalvo jfcalvo merged commit b6b53af into refactor/improve-api-v1-error-handling May 31, 2024
8 checks passed
@jfcalvo jfcalvo deleted the refactor/remove-api-v1-workspaces-exceptions branch May 31, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants