-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] argilla
: simplify structure for flatten records to list
#5137
Merged
frascuchon
merged 3 commits into
develop
from
refactor/simplify-structure-for-flatten-records-to-list
Jul 3, 2024
Merged
[ENHANCEMENT] argilla
: simplify structure for flatten records to list
#5137
frascuchon
merged 3 commits into
develop
from
refactor/simplify-structure-for-flatten-records-to-list
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataliaElv
approved these changes
Jul 2, 2024
burtenshaw
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a real improvement.
One thing though, because responses are an array of values, the flatten
param is no longer true. i.e. the structure is not flat. Should we consider changing the parameter name? For example, we could do nested
and default to True
.
sdiazlor
approved these changes
Jul 3, 2024
Co-authored-by: burtenshaw <[email protected]>
frascuchon
deleted the
refactor/simplify-structure-for-flatten-records-to-list
branch
July 3, 2024 09:11
frascuchon
added a commit
that referenced
this pull request
Jul 3, 2024
# Pull Request Template <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> > [!NOTE] > This PR should be merged after merge #5137 This PR addresses problems when exporting records to dicts including records partially filled. This PR fixes the errors commented in #4936 (comment) Close #4936 **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Bug fix (non-breaking change which fixes an issue) - Refactor (change restructuring the codebase without changing functionality) - Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - follows the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: burtenshaw <[email protected]> Co-authored-by: Ben Burtenshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
This PR changes the structure generated by
to_list(flatten=True)
to simplify reading responses. The response content is split into values and users, so no user ID is defined as part of the column name:The result for the following record:
is :
Refs #4936
Type of change
How Has This Been Tested
Checklist