[ENHANCEMENT] argilla-server: add search support for custom fields
#5461
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y dsl (#5222) # Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> This PR adds a tiny dsl to improve text queries based on [this query](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-simple-query-string-query.html#simple-query-string-syntax) **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> - Improvement (change adding some improvement to an existing functionality) - Documentation update **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Damián Pumar <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/custom-field-support #5461 +/- ##
==========================================================
Coverage 91.16% 91.16%
==========================================================
Files 145 145
Lines 5988 5990 +2
==========================================================
+ Hits 5459 5461 +2
Misses 529 529
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-5461-ki24f765kq-no.a.run.app |
…-search-support-for-custom-fields
burtenshaw
reviewed
Sep 23, 2024
…-search-support-for-custom-fields
frascuchon
changed the title
frascuchon
changed the title
argilla-server: add search support for custom fields
…-search-support-for-custom-fields
burtenshaw
approved these changes
Sep 23, 2024
frascuchon
deleted the
feat/argilla-server/add-search-support-for-custom-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Important
This PR includes some cherry-pick commits from
develop. All branches should be UPDATED before approving and merging this PR.This PR adds support to apply a basic search on custom field values. Inner fields cannot be queried ( for a
record.custom.valuethe search does not support things likecustom.value: some valueType of change
How Has This Been Tested
Checklist