Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove response.upserted webhook event #5494

Merged
merged 4 commits into from
Sep 16, 2024
Merged

feat: remove response.upserted webhook event #5494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d9c6da
chore: move webhooks folder outside api folder
jfcalvo Sep 16, 2024
92372d0
feat: remove response.upserted event and use response.created or resp…
jfcalvo Sep 16, 2024
0028345
chore: reorder webhooks events
jfcalvo Sep 16, 2024
e5f926e
Merge branch 'feat/add-webhooks-feature-branch' into feat/remove-resp…
jfcalvo Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion argilla-server/src/argilla_server/contexts/datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,7 +939,11 @@ async def upsert_response(

await db.commit()
await distribution.update_record_status(search_engine, record.id)
await notify_response_event_v1(db, ResponseEvent.upserted, response)

if response.inserted_at == response.updated_at:
await notify_response_event_v1(db, ResponseEvent.created, response)
else:
await notify_response_event_v1(db, ResponseEvent.updated, response)

return response

Expand Down
28 changes: 13 additions & 15 deletions argilla-server/src/argilla_server/webhooks/v1/enums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,15 @@ class WebhookEvent(str, Enum):
dataset_deleted = "dataset.deleted"
dataset_published = "dataset.published"

response_created = "response.created"
response_updated = "response.updated"
response_deleted = "response.deleted"
response_upserted = "response.upserted"

record_created = "record.created"
record_updated = "record.updated"
record_deleted = "record.deleted"
record_completed = "record.completed"

response_created = "response.created"
response_updated = "response.updated"
response_deleted = "response.deleted"

def __str__(self):
return str(self.value)

Expand All @@ -45,16 +44,6 @@ def __str__(self):
return str(self.value)


class ResponseEvent(str, Enum):
created = WebhookEvent.response_created.value
updated = WebhookEvent.response_updated.value
deleted = WebhookEvent.response_deleted.value
upserted = WebhookEvent.response_upserted.value

def __str__(self):
return str(self.value)


class RecordEvent(str, Enum):
created = WebhookEvent.record_created.value
updated = WebhookEvent.record_updated.value
Expand All @@ -63,3 +52,12 @@ class RecordEvent(str, Enum):

def __str__(self):
return str(self.value)


class ResponseEvent(str, Enum):
created = WebhookEvent.response_created.value
updated = WebhookEvent.response_updated.value
deleted = WebhookEvent.response_deleted.value

def __str__(self):
return str(self.value)
Loading