Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] add custom field mode support #5526

Merged

Conversation

burtenshaw
Copy link
Contributor

Description

Closes #<issue_number>

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon
Copy link
Member

And maybe it makes sense to include here all required changes in the frontend part cc @damianpumar @leiyre

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.15%. Comparing base (7703b1d) to head (1350c4d).
Report is 1 commits behind head on feat/custom-field-support.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           feat/custom-field-support    #5526      +/-   ##
=============================================================
- Coverage                      91.16%   91.15%   -0.02%     
=============================================================
  Files                            145      145              
  Lines                           5990     5993       +3     
=============================================================
+ Hits                            5461     5463       +2     
- Misses                           529      530       +1     
Flag Coverage Δ
argilla-server 91.15% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burtenshaw
Copy link
Contributor Author

And maybe it makes sense to include here all required changes in the frontend part cc @damianpumar @leiyre

Should we merge these SDK changes on to #5422, and then make the frontend changes there?

@burtenshaw burtenshaw merged commit 6f73220 into feat/custom-field-support Sep 24, 2024
10 checks passed
@burtenshaw burtenshaw deleted the enhancement/custom-field-mode-parameter branch September 24, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants