Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] 2.2.1 #5527

Merged
merged 3 commits into from
Sep 23, 2024
Merged

[RELEASE] 2.2.1 #5527

merged 3 commits into from
Sep 23, 2024

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Sep 23, 2024

Description

PR with changes for new patch release 2.2.1.

frascuchon and others added 2 commits September 23, 2024 12:10
# Description
<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. List any
dependencies that are required for this change. -->

Trying this code:

```python
import argilla as rg

client = rg.Argilla(...)

dataset = rg.Dataset.from_hub("google-research-datasets/circa")
```
I found several errors ([Here the source
dataset](https://huggingface.co/datasets/google-research-datasets/circa/viewer/default/train?f[goldstandard2][value]=0)):
- The mapping for records does not match since column names contain
uppercase characters
- Some values for the ClassValue column are unlabelled, making the
uncast process fail (-1)
- Importing cached datasets without config files fails when trying to
read the dataset JSON file.

So, this PR tackles all the problems commented below.



**Type of change**
<!-- Please delete options that are not relevant. Remember to title the
PR according to the type of change -->

- Bug fix (non-breaking change which fixes an issue)

**How Has This Been Tested**
<!-- Please add some reference about how your feature has been tested.
-->

**Checklist**
<!-- Please go over the list and make sure you've taken everything into
account -->

- I added relevant documentation
- I followed the style guidelines of this project
- I did a self-review of my code
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature
works
- I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.19%. Comparing base (e1b2e6e) to head (d1eee08).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5527   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files         145      145           
  Lines        5952     5952           
=======================================
  Hits         5428     5428           
  Misses        524      524           
Flag Coverage Δ
argilla-server 91.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burtenshaw burtenshaw self-requested a review September 23, 2024 10:43
@jfcalvo jfcalvo merged commit d1eee08 into main Sep 23, 2024
20 checks passed
@jfcalvo jfcalvo deleted the releases/2.2.1 branch September 23, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants