Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The important part here is
first
andlast
inHCursor
—the current implementations have copy-paste errors that mean that these operations are broken on bothHCursor
andACursor
.I've also corrected a couple of similar cases of copy-paste errors in history tracking, and added two missing
CursorOpElement
types. I've made up what I think are reasonable string representations for these, but I'm happy to change them.I haven't added any tests, since
HCursor
isn't currently tested directly. I'd be happy to add something for this in a separate PR.