chore: change module name to line up with naming convention #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argoproj/argo-rollouts#2720 Signed-off-by: mitchell amihod <[email protected]>
meeech
force-pushed
the
change-plugin-naming-pattern-ar-issue-2720
branch
from
a94b1dd
to
b1c0705
Compare
meeech
commented
Apr 14, 2023
| @@ -24,7 +24,7 @@ func main() { | |||
| LogCtx: logCtx, | |||
| } | |||
| // pluginMap is the map of plugins we can dispense. | |||
| var pluginMap = map[string]goPlugin.Plugin{ | |||
| pluginMap := map[string]goPlugin.Plugin{ | |||
There was a problem hiding this comment.
let me know if this needs to be removed. I have gofumpt on by default
6 tasks
zachaller
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to argoproj/argo-rollouts#2720