Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod logs are displayed as line numbers #14402

Closed
3 tasks done
terrytangyuan opened this issue Jul 7, 2023 · 3 comments · Fixed by #14543
Closed
3 tasks done

Pod logs are displayed as line numbers #14402

terrytangyuan opened this issue Jul 7, 2023 · 3 comments · Fixed by #14543
Assignees
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements

Comments

@terrytangyuan
Copy link
Member

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

I have a pod that just prints out 1-160 but they are displayed as line numbers in the log viewer.

To Reproduce

The following is the pod spec:

apiVersion: v1
kind: Pod
metadata:
  name: intentional-fail
spec:
  containers:
  - name: fail
    image: bash:4.4
    command: ["bash", "-c"]
    args:
    - |
      set -eu
      for i in {1..160}; do echo $i; done;
      exit 1

Expected behavior

The actual numbers printed out should also be in the log viewer.

Screenshots

Screen Shot 2023-07-03 at 2 55 10 PM

@terrytangyuan terrytangyuan added the bug Something isn't working label Jul 7, 2023
@alexec
Copy link
Contributor

alexec commented Jul 16, 2023

I don’t think these are printed as line numbers, I think maybe the viewer’s width is too narrow.

@alexec alexec self-assigned this Jul 16, 2023
@alexec alexec added the component:ui User interfaces bugs and enhancements label Jul 16, 2023
@alexec
Copy link
Contributor

alexec commented Jul 16, 2023

That line should be columnWidth={Math.max(width, maxWidth)}.

@alexec
Copy link
Contributor

alexec commented Jul 16, 2023

@terrytangyuan @crenshaw-dev I don’t have access to adequate compute resources to fix this right now. I think the fix is small, but problem is probably not top priority either.

terrytangyuan added a commit to terrytangyuan/argo-cd that referenced this issue Jul 17, 2023
crenshaw-dev pushed a commit that referenced this issue Jul 18, 2023
crenshaw-dev pushed a commit that referenced this issue Jul 18, 2023
Jneville0815 pushed a commit to radiusmethod/argo-cd that referenced this issue Jul 18, 2023
schakrad pushed a commit to schakrad/argo-cd that referenced this issue Jul 24, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this issue Aug 9, 2023
tesla59 pushed a commit to tesla59/argo-cd that referenced this issue Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements
Projects
None yet
2 participants