Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application-controller listing deployments since v2.9.3 #16668

Closed
3 tasks done
therealdwright opened this issue Dec 21, 2023 · 3 comments
Closed
3 tasks done

application-controller listing deployments since v2.9.3 #16668

therealdwright opened this issue Dec 21, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@therealdwright
Copy link

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

Since upgrading to v2.9.3 the application controller has started listing deployments causing large volumes of access denied events.

To Reproduce

Upgrade to v2.9.3 using namespace install and observe events from system:serviceaccount:argocd:argocd-application-controller listing v1/deployments

Expected behavior

Access is granted if this call is necessary.

Screenshots

Version

argocd-application-controller/v2.9.3+6eba5be (linux/amd64)

@therealdwright
Copy link
Author

I attempted to patch the RBAC with the list deployments permission, and then it started performing watch on deployments. Is it expected in the new release for ArgoCD to perform these operations? I want to verify before continuing to add more RBAC.

@crenshaw-dev
Copy link
Member

It is expected. I believe @ishitasequeira plans to open a PR to add the necessary RBAC.

@jgwest
Copy link
Member

jgwest commented Mar 28, 2024

Fixed by #16785

@jgwest jgwest closed this as completed Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants