Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manifests): allow list deployments in application controller #16670

Closed

Conversation

therealdwright
Copy link

@therealdwright therealdwright commented Dec 21, 2023

Since upgrading to v2.9.3 the application controller has started
trying to list deployments causing large volumes of access denied
events. This adds apps list deployments to provide argo the access
it needs.

Signed-off-by: Daniel Wright [email protected]

Closes #16668

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Since upgrading to v2.9.3 the application controller has started
trying to list deployments causing large volumes of access denied
events. This adds apps list deployments to provide argo the access
it needs.

Signed-off-by: Daniel Wright <[email protected]>
@therealdwright therealdwright requested a review from a team as a code owner December 21, 2023 06:27
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3224102) 49.48% compared to head (a0dbb1f) 49.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #16670   +/-   ##
=======================================
  Coverage   49.48%   49.48%           
=======================================
  Files         271      271           
  Lines       47726    47726           
=======================================
  Hits        23619    23619           
  Misses      21772    21772           
  Partials     2335     2335           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishitasequeira
Copy link
Member

The changes have been implemented in #16785. We can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

application-controller listing deployments since v2.9.3
2 participants