Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive HTTP requests and therefore API calls when navigating in list view #17756

Closed
3 tasks done
adberger opened this issue Apr 5, 2024 · 0 comments · Fixed by #17757
Closed
3 tasks done

Excessive HTTP requests and therefore API calls when navigating in list view #17756

adberger opened this issue Apr 5, 2024 · 0 comments · Fixed by #17757
Assignees
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements

Comments

@adberger
Copy link
Contributor

adberger commented Apr 5, 2024

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

It seems that when navigating in list view, the ArgoCD UI make several requests for each resource even if it's not necessary.
For example if exec is enabled, every resource is checked if exec is allowed, even if it's not a pod.

On tree view this happens only when clicking on the 3 dots.
On list view this happens in the overview.

The following endpoints are called too many times:

  1. /api/v1/settings
  2. /api/v1/applications/guestbook/resource/actions?appNamespace=argocd&namespace=default&resourceName=guestbook-ui-56c646849b-2qsm5&version=v1&kind=Pod
  3. /api/v1/applications/guestbook/resource/links?name=guestbook-ui-56c646849b-2qsm5&appNamespace=argocd&namespace=default&resourceName=guestbook-ui-56c646849b-2qsm5&version=v1&kind=Pod&group=
  4. /api/v1/account/can-i/exec/create/default/<resource name>

To Reproduce

  • kind create cluster --name argocd
  • kubectl create namespace argocd
  • kubectl apply -n argocd -f https://raw.githubusercontent.com/argoproj/argo-cd/stable/manifests/install.yaml
  • Create Application
  • kubectl scale --replicas 10 -n default deploy guestbook-ui (to better see the extent of the problem)

Expected behavior

  1. The endpoints (at least /api/v1/account/can-i/exec/create/default/<resource name>) should only be called when clicking on the 3 dots.
  2. The endpoint /api/v1/account/can-i/exec/create/default/<resource name> should only be called when clicking on a pod.

Be careful not to introduce old bugs, see references in Related heading.

Video

list-view.mp4

Version

{
    "Version": "v2.10.4+f5d63a5",
    "BuildDate": "2024-03-18T08:09:23Z",
    "GitCommit": "f5d63a5c77d2e804e51ef94bee3db441e0789d00",
    "GitTreeState": "clean",
    "GoVersion": "go1.21.3",
    "Compiler": "gc",
    "Platform": "linux/amd64",
    "KustomizeVersion": "v5.2.1 2023-10-19T20:13:51Z",
    "HelmVersion": "v3.14.3+gf03cc04",
    "KubectlVersion": "v0.26.11",
    "JsonnetVersion": "v0.20.0"
}

Related

@adberger adberger added the bug Something isn't working label Apr 5, 2024
@jannfis jannfis added the component:ui User interfaces bugs and enhancements label Apr 5, 2024
@ashutosh16 ashutosh16 self-assigned this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants