fix(ui): add exec check to avoid API calls #16168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashutosh16
force-pushed
the
bug/mutliple-can-I-exec
branch
from
6a613e0
to
1da3a42
Compare
ashutosh16
force-pushed
the
bug/mutliple-can-I-exec
branch
from
1e3f194
to
f1b9c5f
Compare
ashutosh16
changed the title
ashutosh16
force-pushed
the
bug/mutliple-can-I-exec
branch
2 times, most recently
from
958ef84
to
732db13
Compare
|
Fix - 1 
Fix -2 Screen.Recording.2023-10-30.at.8.08.56.PM.mov |
ashutosh16
force-pushed
the
bug/mutliple-can-I-exec
branch
2 times, most recently
from
f5b4023
to
cb1c75a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16168 +/- ##
=======================================
Coverage 49.53% 49.53%
=======================================
Files 269 269
Lines 47321 47321
=======================================
Hits 23441 23441
Misses 21576 21576
Partials 2304 2304 ☔ View full report in Codecov by Sentry. |
|
@ishitasequeira Would it be possible for you to test my changes. There are two issues that this PR addresses.
|
Sure, I will test it out this week. |
|
@ashutosh16 can you include |
ashutosh16
changed the title
ishitasequeira
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Thanks @ashutosh16, I tested the change and the changes look good to me.
ui/src/app/applications/components/application-details/application-resource-list.tsx
Outdated
Show resolved
Hide resolved
keithchong
reviewed
Nov 4, 2023
ui/src/app/applications/components/resource-details/resource-details.tsx
Outdated
Show resolved
Hide resolved
keithchong
reviewed
Nov 4, 2023
ui/src/app/applications/components/application-details/application-resource-list.tsx
Show resolved
Hide resolved
keithchong
reviewed
Nov 4, 2023
ui/src/app/applications/components/application-details/application-resource-list.tsx
Outdated
Show resolved
Hide resolved
ashutosh16
force-pushed
the
bug/mutliple-can-I-exec
branch
from
cb1c75a
to
33882e5
Compare
ashutosh16
force-pushed
the
bug/mutliple-can-I-exec
branch
from
c843c7f
to
96ac0e2
Compare
|
@keithchong /@ishitasequeira Would you be able to merge the PR? |
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
ashutosh16
force-pushed
the
bug/mutliple-can-I-exec
branch
from
96ac0e2
to
d253053
Compare
ishitasequeira
approved these changes
Nov 30, 2023
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
* bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> --------- Signed-off-by: ashutosh16 <[email protected]>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
* bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> --------- Signed-off-by: ashutosh16 <[email protected]>
JulienFuix
pushed a commit
to JulienFuix/argo-cd
that referenced
this pull request
Feb 6, 2024
* bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> --------- Signed-off-by: ashutosh16 <[email protected]>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
* bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> --------- Signed-off-by: ashutosh16 <[email protected]> Signed-off-by: Kevin Lyda <[email protected]>
3 tasks
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
* bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> * bug: add parent ref node info on resource list Signed-off-by: ashutosh16 <[email protected]> --------- Signed-off-by: ashutosh16 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16165
Along with this PR, fixing UI bug on the resource list when pod group is enabled and total pod count is grater than 15
UI displays Parent Node Ref details which shouldn't be displayed on this list view. Parent Ref details should only be displayed when the user clicks on the pod group on the tree view