Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need complete audit trail #340

Closed
edlee2121 opened this issue Jun 29, 2018 · 2 comments
Closed

Need complete audit trail #340

edlee2121 opened this issue Jun 29, 2018 · 2 comments
Assignees
@alexmt
Milestone
0.7.0

Comments

@edlee2121
Copy link
Contributor

No description provided.

@jessesuen jessesuen added this to the 0.7.0 milestone Jul 3, 2018
@jessesuen
Copy link
Member

Two things to do here:

  1. A gRPC interceptor should be added to log all API server requests with details about the authenticated user and relevant parameters of the request. Ideally this would be done in a generic way. This may be possible using the reflect package to check for known fields (e.g. name, server).

  2. Application controller should start emitting K8s events on everything that happens to an application (e.g. sync completed, presync failed, etc...)

@alexmt alexmt assigned alexmt and unassigned jessesuen Jul 18, 2018
@alexmt
Copy link
Collaborator

alexmt commented Jul 18, 2018

working on it

@jessesuen jessesuen added the P1 label Jul 18, 2018
@jessesuen jessesuen changed the title Need complete audit trail [SPIKE] Need complete audit trail Jul 18, 2018
alexmt pushed a commit to alexmt/argo-cd that referenced this issue Jul 19, 2018
Issue argoproj#340 - add gRPC payload logging interceptor
fbf7891
@jessesuen jessesuen added the 5 label Jul 19, 2018
@jessesuen jessesuen changed the title [SPIKE] Need complete audit trail Need complete audit trail Jul 19, 2018
alexmt added a commit that referenced this issue Jul 19, 2018
@alexmt
Issue #340 - add gRPC payload logging interceptor (#434)
0591f2b
alexmt pushed a commit to alexmt/argo-cd that referenced this issue Jul 20, 2018
Issue argoproj#340 - create application/project events for audit
5cf885f
alexmt added a commit that referenced this issue Jul 24, 2018
@alexmt
Issue #340 - create application/project events for audit (#440)
b3af671 
* Issue #340 - create application/project events for audit

* Issue 340 - move username to message field

* Reviewer notes: fix possible panic
@alexmt alexmt closed this as completed Jul 24, 2018
alexec pushed a commit that referenced this issue Apr 24, 2019
Issue #340 - render application events
95b237b
alexec pushed a commit that referenced this issue Apr 24, 2019
@alexmt
Merge pull request #20 from alexmt/340-app-events-ui
83d0c4b 
Issue #340 - render application events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexmt alexmt

Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
3 participants
@alexmt @jessesuen @edlee2121