Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): deep links example fix #13855

Merged
merged 1 commit into from
May 31, 2023

Conversation

gdsoumya
Copy link
Member

Fixes #12851

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) May 31, 2023 16:38
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.7

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (42479f5) 49.25% compared to head (1e5078f) 49.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13855   +/-   ##
=======================================
  Coverage   49.25%   49.25%           
=======================================
  Files         251      251           
  Lines       43521    43521           
=======================================
  Hits        21438    21438           
  Misses      19949    19949           
  Partials     2134     2134           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev merged commit 60b7a31 into argoproj:master May 31, 2023
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request May 31, 2023
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
crenshaw-dev pushed a commit that referenced this pull request May 31, 2023
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
Co-authored-by: Soumya Ghosh Dastidar <[email protected]>
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Jul 24, 2023
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
Co-authored-by: Soumya Ghosh Dastidar <[email protected]>
Signed-off-by: schakrad <[email protected]>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deeplink if "field exists" check not working.
2 participants