fix(cmp): send sigterm to cmp commands before sigkill to allow for potential cleanup (#9180) (cherry-pick #14955) #14958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
…tential cleanup (#9180) (#14955) * fix: send sigterm to cmp commands before sigkill to allow for potential cleanup Signed-off-by: Ashin Sabu <[email protected]> * fix: unit test for runCommand in cmpserver to test cleanup modified Signed-off-by: Ashin Sabu <[email protected]> * fix: change unit test for plugin/runCommand to avoid bad trap along with lint fix Signed-off-by: Ashin Sabu <[email protected]> --------- Signed-off-by: Ashin Sabu <[email protected]>
crenshaw-dev
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix(cmp): send sigterm to cmp commands before sigkill to allow for potential cleanup (#9180) (#14955)
Signed-off-by: Ashin Sabu [email protected]
Signed-off-by: Ashin Sabu [email protected]
Signed-off-by: Ashin Sabu [email protected]
Signed-off-by: Ashin Sabu [email protected]