Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extends clusterRole to allow cronjob and Argo workflows triggers #15300

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

tchellomello
Copy link
Contributor

@tchellomello tchellomello commented Aug 31, 2023

Fixes: #15298

Extends the argocd-server ClusterRole to allow triggering cronjobs and Argo workflows via UI.

Similar to: https://github.com/argoproj/argo-helm/pull/2212/files

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bd58788) 49.96% compared to head (6da6dae) 49.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #15300   +/-   ##
=======================================
  Coverage   49.96%   49.96%           
=======================================
  Files         263      263           
  Lines       45262    45262           
=======================================
+ Hits        22613    22616    +3     
+ Misses      20429    20427    -2     
+ Partials     2220     2219    -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@morey-tech morey-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Looks like that was missed in #12925. The helm chart implemented the same fix on their end argoproj/argo-helm#2212

Copy link
Member

@34fathombelow 34fathombelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome find!

@tchellomello tchellomello changed the title fix: extends clusterRole to allow cronjob trigger fix: extends clusterRole to allow cronjob and workflows triggers Sep 5, 2023
@tchellomello tchellomello changed the title fix: extends clusterRole to allow cronjob and workflows triggers fix: extends clusterRole to allow cronjob and Argo workflows triggers Sep 5, 2023
Co-authored-by: Nicholas Morey <[email protected]>
Signed-off-by: Marcelo Moreira de Mello <[email protected]>
@tchellomello
Copy link
Contributor Author

@terrytangyuan @34fathombelow @morey-tech Thanks so much for your time reviewing the PR. Guys, is there anything else is needed on my end to get this merged? Thank you so much!

@terrytangyuan
Copy link
Member

We'll need someone with approval status to perform final approve and merge: https://github.com/argoproj/argo-cd/blob/master/OWNERS#L5-L16

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannfis jannfis merged commit ce026de into argoproj:master Sep 13, 2023
22 checks passed
@jannfis
Copy link
Member

jannfis commented Sep 13, 2023

/cherry-pick release-2.8

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 13, 2023
Signed-off-by: Marcelo Moreira de Mello <[email protected]>
Co-authored-by: Nicholas Morey <[email protected]>
jannfis pushed a commit that referenced this pull request Sep 13, 2023
Signed-off-by: Marcelo Moreira de Mello <[email protected]>
Co-authored-by: Marcelo Mello <[email protected]>
Co-authored-by: Nicholas Morey <[email protected]>
@tchellomello tchellomello deleted the add-jobs-rbac-v28-feature branch September 13, 2023 18:44
Jneville0815 pushed a commit to radiusmethod/argo-cd that referenced this pull request Sep 30, 2023
Signed-off-by: Marcelo Moreira de Mello <[email protected]>
Co-authored-by: Nicholas Morey <[email protected]>
Signed-off-by: Jimmy Neville <[email protected]>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
Signed-off-by: Marcelo Moreira de Mello <[email protected]>
Co-authored-by: Nicholas Morey <[email protected]>
Signed-off-by: jmilic1 <[email protected]>
gczuczy pushed a commit to gczuczy/argo-cd that referenced this pull request Dec 11, 2023
* backfill cache control header tests for ui assets

Signed-off-by: Scott Windsor <[email protected]>

* Set cache-control header non-cache for assets not found

Signed-off-by: Scott Windsor <[email protected]>

* fix golang-cilint warning

Signed-off-by: Scott Windsor <[email protected]>

---------

Signed-off-by: Scott Windsor <[email protected]>

docs: Fixes a markdown typo in USERS.md (#15362)

This removes the whitespace between the link text and the link URL.

Signed-off-by: Prasad Katti <[email protected]>

feat: upgrade notification engine (#15359)

* Update notifications-engine dependencies

Signed-off-by: Mike Splain <[email protected]>

* Update docs

Signed-off-by: Mike Splain <[email protected]>

---------

Signed-off-by: Mike Splain <[email protected]>
Co-authored-by: pasha-codefresh <[email protected]>

feat: add Dott to users (#15370)

Signed-off-by: Jake Burn <[email protected]>

fix(notifications-catalog): Add nil check for on-deployed trigger (#15363)

Signed-off-by: Fs02 <[email protected]>
Co-authored-by: pasha-codefresh <[email protected]>

feat: auto respect rbac for discovery/sync (#14381)

feat: auto respect rbac for discovery/sync (#14381)

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

feat: Add ARGOCD_CLUSTER_CACHE_LIST_PAGE_BUFFER_SIZE environment variable (#15159)

Signed-off-by: Brad West <[email protected]>

fix(appset): Revert applicationset-name labels (#15324)

* fix(15282) Revert applicationset-name labels

Signed-off-by: gmuselli <[email protected]>

* fix(15282) fix unit test

Signed-off-by: gmuselli <[email protected]>

---------

Signed-off-by: gmuselli <[email protected]>

chore(deps): bump library/golang from 1.21.0 to 1.21.1 (#15391)

Bumps library/golang from 1.21.0 to 1.21.1.

---
updated-dependencies:
- dependency-name: library/golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump library/golang from 1.21.0 to 1.21.1 in /test/remote (#15387)

Bumps library/golang from 1.21.0 to 1.21.1.

---
updated-dependencies:
- dependency-name: library/golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump library/node from 20.4.0 to 20.6.0 in /test/container (#15366)

Bumps library/node from 20.4.0 to 20.6.0.

---
updated-dependencies:
- dependency-name: library/node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Merge pull request from GHSA-g687-f2gx-6wm8

* feat: use untar with limiter

Signed-off-by: pashakostohrys <[email protected]>

* feat: use untar with limiter

Signed-off-by: pashakostohrys <[email protected]>

---------

Signed-off-by: pashakostohrys <[email protected]>

Merge pull request from GHSA-fwr2-64vr-xv9m

* fix: prevent seeing/editing 'kubectl.kubernetes.io/last-applied-configuration' cluster annotation

Signed-off-by: Alexander Matyushentsev <[email protected]>

* fix: failing unit test

Signed-off-by: iam-veeramalla <[email protected]>

---------

Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: iam-veeramalla <[email protected]>
Co-authored-by: iam-veeramalla <[email protected]>

chore(deps): bump library/node from 20.5.0 to 20.6.0 in /ui-test (#15364)

Bumps library/node from 20.5.0 to 20.6.0.

---
updated-dependencies:
- dependency-name: library/node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix: handle annotations for resources with ':' in the name (#15101) (#15380)

* fix: handle annotations for resources with ':' in the name

Signed-off-by: Oreon Lothamer <[email protected]>

* fix: switch to using splitN for handling annotation splitting

Signed-off-by: Oreon Lothamer <[email protected]>

* fix: check len(parts) !=3

Signed-off-by: Oreon Lothamer <[email protected]>

* Retrigger CI pipeline

Signed-off-by: Oreon Lothamer <[email protected]>

---------

Signed-off-by: Oreon Lothamer <[email protected]>

docs: Improve RBAC documentation (#15430)

* Improve staging-db project name

This change renames the project to distinguish it from the role.

Signed-off-by: Andreas Lindhé <[email protected]>

* Rename db-staging role to singular form

Role names should be singular ("User x has the role admin" as opposed to
"User x has the role admins").

Signed-off-by: Andreas Lindhé <[email protected]>

* Remove trailing newlines

Signed-off-by: Andreas Lindhé <[email protected]>

* Consistently mark `AppProject` as code

Signed-off-by: Andreas Lindhé <[email protected]>

* Replace ```shell with ```console in suitable places

Signed-off-by: Andreas Lindhé <[email protected]>

* Use consistent style for unordered list

https://github.com/DavidAnson/markdownlint/blob/main/doc/md004.md

Signed-off-by: Andreas Lindhé <[email protected]>

* Use consistent emphasis style

https://github.com/DavidAnson/markdownlint/blob/main/doc/md049.md

Signed-off-by: Andreas Lindhé <[email protected]>

* Fix incorrect description of the staging-db example

Signed-off-by: Andreas Lindhé <[email protected]>

---------

Signed-off-by: Andreas Lindhé <[email protected]>

fix(appsets): gotemplate can cause panic from nil dereference (#15377) (#15378)

* fix(appsets): gotemplate can cause panic from nil deference

Signed-off-by: rumstead <[email protected]>

* fix(appsets): gotemplate can cause panic from nil dereference

Signed-off-by: rumstead <[email protected]>

---------

Signed-off-by: rumstead <[email protected]>

chore: Fix flaky cluster test (#15433)

Fix requeue after for Matrix/Merge with SCM or ClusterDecision generators (#15407)

Signed-off-by: Cezar Sa Espinola <[email protected]>

feat: added shorthand flags for follow and conatainre in app logs (#15400)

* feat: added shorthand flags for follow and conatainre in app logs

Signed-off-by: ashu <[email protected]>

* doc: re-generated cli docs

Signed-off-by: ashu <[email protected]>

---------

Signed-off-by: ashu <[email protected]>
Co-authored-by: jannfis <[email protected]>

[Bot] docs: Update Snyk reports (#15437)

Signed-off-by: CI <[email protected]>
Co-authored-by: CI <[email protected]>
Co-authored-by: jannfis <[email protected]>

fix: Better enforcement of application namespace restrictions (#15431)

* fix: Better enforce application namespace restrictions

Signed-off-by: jannfis <[email protected]>

* Only call ValidateDestination when allowed

Signed-off-by: jannfis <[email protected]>

---------

Signed-off-by: jannfis <[email protected]>

docs: fix bullets (#15446)

Signed-off-by: Josh Soref <[email protected]>

fix: failed to add cluster when the cluster server address is ipv6 (#8204) (#15350)

* fix: failed to add cluster when the cluster server address is ipv6 (#8204)

Signed-off-by: huyinhou <[email protected]>

* fix: failed to add cluster when the cluster server address is ipv6 (#8204)

Signed-off-by: huyinhou <[email protected]>

* remove unused import

Signed-off-by: huyinhou <[email protected]>

* fix: lowercase URI secret name; abbreviated IPv6 address

Signed-off-by: huyinhou <[email protected]>

---------

Signed-off-by: huyinhou <[email protected]>

feat: Enable haproxy metrics through helm Chart (#15459)

Signed-off-by: Mathias Petermann <[email protected]>

Stop appending :443 to the server address when using grpc-web (#15435)

Signed-off-by: David Marby <[email protected]>
Co-authored-by: jannfis <[email protected]>

feat: appset preserve labels and global preserve fields (#15445)

* feat: appset preserve labels and global preserve fields

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

* feat: appset preserve labels and global preserve fields

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

* docs: updated docs

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

* docs: updated docs

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

---------

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

fix: Gitlab scm_provider - don't create transport from scratch (#15424) (#15425)

* fix : don't create transport from scratch, clone it instead

Signed-off-by: Antoine Jouve <[email protected]>

* feat: clone http.transport for gitea and gitlab providers

Signed-off-by: Antoine Jouve <[email protected]>

* chore: properly format gitea providers with gofmt

Signed-off-by: Antoine Jouve <[email protected]>

---------

Signed-off-by: Antoine Jouve <[email protected]>

chore: add Factorial to USERS.md (#15473)

Signed-off-by: Alejandro López Sánchez <[email protected]>

Fix incorrect wording in ApplicationSet git generator docs (#15374)

Signed-off-by: Liam Wyllie <[email protected]>

fix: Allow retrieving badges in other namespaces (#15468)

Signed-off-by: jannfis <[email protected]>

chore(deps): bump docker/setup-buildx-action from 2.9.1 to 3.0.0 (#15476)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.9.1 to 3.0.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](https://github.com/docker/setup-buildx-action/compare/4c0219f9ac95b02789c1075625400b2acbff50b1...f95db51fddba0c2d1ec667646a06c2ce06100226)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump library/node from 20.6.0 to 20.6.1 in /test/container (#15451)

Bumps library/node from 20.6.0 to 20.6.1.

---
updated-dependencies:
- dependency-name: library/node
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump library/node from 20.6.0 to 20.6.1 in /ui-test (#15452)

Bumps library/node from 20.6.0 to 20.6.1.

---
updated-dependencies:
- dependency-name: library/node
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump gitpod/workspace-full from `d578722` to `511cecd` (#15453)

Bumps gitpod/workspace-full from `d578722` to `511cecd`.

---
updated-dependencies:
- dependency-name: gitpod/workspace-full
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump argo-ui from `13cea62` to `002d01b` in /ui (#15440)

Bumps [argo-ui](https://github.com/argoproj/argo-ui) from `13cea62` to `002d01b`.
- [Release notes](https://github.com/argoproj/argo-ui/releases)
- [Commits](https://github.com/argoproj/argo-ui/compare/13cea62a4a0e4a14a2dd6908490e1e907709aa86...002d01b18e8aaf4b21307a3b87341ab05230483f)

---
updated-dependencies:
- dependency-name: argo-ui
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump library/golang in /test/remote (#15419)

Bumps library/golang from `970907c` to `62e5883`.

---
updated-dependencies:
- dependency-name: library/golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump library/golang from `970907c` to `62e5883` (#15415)

Bumps library/golang from `970907c` to `62e5883`.

---
updated-dependencies:
- dependency-name: library/golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix(controller): make managed namespaces more 'prune-proof' (#13999)

* fix: make managed namespaces more 'prune-proof'

In the cases where someone would want to set resource tracking on a
managed namespace, or if someone would want to migrate from having a
namespace in Git to using `managedNamespaceMetadata`, we need to take
steps to ensure that the namespace does not get pruned.

In order to do that, we add the live namespace to the list of
`targetObjs` (so that it's considered a part of the source even though
it's not).

Finally, we need to also ensure that the managed namespace is not
considered `OutOfSync` (due to the same reason as above).

This is a subset of #11350, the main difference being that this commit
does not set resource tracking on its own, but can be opted into if
people choose to do so.

Signed-off-by: Blake Pettersson <[email protected]>

* refactor: extract managed namespace check

Signed-off-by: Blake Pettersson <[email protected]>

---------

Signed-off-by: Blake Pettersson <[email protected]>

fix: extends CR to allow cronjob/workflow triggers (#15300)

Signed-off-by: Marcelo Moreira de Mello <[email protected]>
Co-authored-by: Nicholas Morey <[email protected]>

chore(deps): bump library/node from 20.5.0 to 20.6.1 (#15454)

Bumps library/node from 20.5.0 to 20.6.1.

---
updated-dependencies:
- dependency-name: library/node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jannfis <[email protected]>

chore(deps): bump github.com/cyphar/filepath-securejoin (#15401)

Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.2.3 to 0.2.4.
- [Release notes](https://github.com/cyphar/filepath-securejoin/releases)
- [Commits](https://github.com/cyphar/filepath-securejoin/compare/v0.2.3...v0.2.4)

---
updated-dependencies:
- dependency-name: github.com/cyphar/filepath-securejoin
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

(docs) Add clarification on migration for CMP plugins (#15405)

* Add clarification on migration for CMP plugins

Signed-off-by: Dan Garfield <[email protected]>

* Fix table

Signed-off-by: Dan Garfield <[email protected]>

* Add warning on blank manifests for #15340

Signed-off-by: Dan Garfield <[email protected]>

---------

Signed-off-by: Dan Garfield <[email protected]>

chore(deps): bump sigstore/cosign-installer from 3.1.1 to 3.1.2 (#15330)

Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/sigstore/cosign-installer/releases)
- [Commits](https://github.com/sigstore/cosign-installer/compare/6e04d228eb30da1757ee4e1dd75a0ec73a653e06...11086d25041f77fe8fe7b9ea4e48e3b9192b8f19)

---
updated-dependencies:
- dependency-name: sigstore/cosign-installer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump github.com/xanzy/go-gitlab from 0.89.0 to 0.91.1 (#15331)

Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab) from 0.89.0 to 0.91.1.
- [Changelog](https://github.com/xanzy/go-gitlab/blob/master/releases_test.go)
- [Commits](https://github.com/xanzy/go-gitlab/compare/v0.89.0...v0.91.1)

---
updated-dependencies:
- dependency-name: github.com/xanzy/go-gitlab
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

docs: Add KPMG to users (#15323)

Signed-off-by: Ansuman Swain <[email protected]>
Co-authored-by: jannfis <[email protected]>

Fix broken links for post selectors, fix ordering of args for dig example (#15346)

Signed-off-by: David Muckle <[email protected]>

chore(deps): bump library/golang in /test/container (#15502)

Bumps library/golang from 1.21.0 to 1.21.1.

---
updated-dependencies:
- dependency-name: library/golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump github.com/casbin/casbin/v2 from 2.73.0 to 2.77.2 (#15501)

Bumps [github.com/casbin/casbin/v2](https://github.com/casbin/casbin) from 2.73.0 to 2.77.2.
- [Release notes](https://github.com/casbin/casbin/releases)
- [Changelog](https://github.com/casbin/casbin/blob/master/.releaserc.json)
- [Commits](https://github.com/casbin/casbin/compare/v2.73.0...v2.77.2)

---
updated-dependencies:
- dependency-name: github.com/casbin/casbin/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump actions/upload-artifact from 3.1.2 to 3.1.3 (#15497)

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.2 to 3.1.3.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/0b7f8abb1508181956e8e162db84b466c27e18ce...a8a3f3ad30e3422c9c7b888a15615d19a852ae32)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jannfis <[email protected]>

fix(cli): fix header in resource-overrides list-actions output (#15375)

Signed-off-by: Maxime Brunet <[email protected]>

chore: adding tests for apiclient package: clientset tests (#15193)

Signed-off-by: zhaque44 <[email protected]>

fix: Applicationset upsert for any namespaces (#15520)

* fix: Applicationset upsert for any namespaces

PR implements a small change to the argocd command adding the AppsetNamespace for the existing Appset check.

Signed-off-by: Harm Matthias Harms <[email protected]>

* Retrigger CI pipeline

Signed-off-by: Harm Matthias Harms <[email protected]>

* Retrigger CI pipeline

Signed-off-by: Harm Matthias Harms <[email protected]>

---------

Signed-off-by: Harm Matthias Harms <[email protected]>

chore: update ordering of support steps (#15508)

Signed-off-by: Kurt King <[email protected]>

feat: add option in output flag for app get and app resources cli command for tree view(#13370) (#15386)

* tree view feature for app get cli comand

Signed-off-by: schakrad <[email protected]>

* including application details

Signed-off-by: schakrad <[email protected]>

* testcase included for printTreeView

Signed-off-by: schakrad <[email protected]>

* removed the unnecessary variables

Signed-off-by: schakrad <[email protected]>

* Adding changes to the documentation

Signed-off-by: schakrad <[email protected]>

* change in the argocd doc

Signed-off-by: schakrad <[email protected]>

* included tee_test.go

Signed-off-by: schakrad <[email protected]>

* tree view changes for app get and app resources

Signed-off-by: schakrad <[email protected]>

* go.mod and go.sum by running go mod tidy

Signed-off-by: schakrad <[email protected]>

* changes after review

Signed-off-by: schakrad <[email protected]>

* changes after review

Signed-off-by: schakrad <[email protected]>

---------

Signed-off-by: schakrad <[email protected]>

chore(deps): bump github.com/go-playground/webhooks/v6 (#15516)

Bumps [github.com/go-playground/webhooks/v6](https://github.com/go-playground/webhooks) from 6.2.1-0.20230808162451-10570b0a59e8 to 6.3.0.
- [Release notes](https://github.com/go-playground/webhooks/releases)
- [Commits](https://github.com/go-playground/webhooks/commits/v6.3.0)

---
updated-dependencies:
- dependency-name: github.com/go-playground/webhooks/v6
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix: ApplicationSet deletes Application status (#15514)

* fix: ApplicationSet deletes Application status

Signed-off-by: Alexander Matyushentsev <[email protected]>

* apply reviewer notes

Signed-off-by: Alexander Matyushentsev <[email protected]>

---------

Signed-off-by: Alexander Matyushentsev <[email protected]>

docs: Update Application Set Webhook Instructions (#13764, #11532) (#15527)

* Update Generators-Pull-Request.md

Add note to clarify that the ApplicationSet controller requires its own Ingress resource. This seems to be a common issue for Argo CD users.

Signed-off-by: Kurt Madel <[email protected]>

* Update Generators-Git.md

Updating note to match webhook note on pr generator.

Signed-off-by: Kurt Madel <[email protected]>

---------

Signed-off-by: Kurt Madel <[email protected]>

chore: Add 4data to users (#15531)

Signed-off-by: LStuker <[email protected]>

docs: fix kubectl apply in apps-in-any-namespace doc (#15197)

There's a kustomization.yaml file in that directory, so we should apply it with `-k`.

Signed-off-by: Michael Crenshaw <[email protected]>

docs: Fix docs for destinations in AppProjects (#15153) (#15182)

Signed-off-by: Andreas Lindhé <[email protected]>

chore(deps): bump github.com/ktrysmt/go-bitbucket from 0.9.63 to 0.9.67 (#15500)

Bumps [github.com/ktrysmt/go-bitbucket](https://github.com/ktrysmt/go-bitbucket) from 0.9.63 to 0.9.67.
- [Release notes](https://github.com/ktrysmt/go-bitbucket/releases)
- [Commits](https://github.com/ktrysmt/go-bitbucket/compare/v0.9.63...v0.9.67)

---
updated-dependencies:
- dependency-name: github.com/ktrysmt/go-bitbucket
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jannfis <[email protected]>

chore(deps): bump goreleaser/goreleaser-action from 4.4.0 to 5.0.0 (#15496)

Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 4.4.0 to 5.0.0.
- [Release notes](https://github.com/goreleaser/goreleaser-action/releases)
- [Commits](https://github.com/goreleaser/goreleaser-action/compare/3fa32b8bb5620a2c1afe798654bbad59f9da4906...7ec5c2b0c6cdda6e8bbb49444bc797dd33d74dd8)

---
updated-dependencies:
- dependency-name: goreleaser/goreleaser-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[Bot] docs: Update Snyk reports (#15532)

Signed-off-by: CI <[email protected]>
Co-authored-by: CI <[email protected]>

chore(deps): bump actions/checkout from 3.5.3 to 4.0.0 (#15348)

* chore(deps): bump actions/checkout from 3.5.3 to 4.0.0

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 4.0.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/c85c95e3d7251135ab7dc9ce3241c5835cc595a9...3df4ab11eba7bda6032a0b82a6bb43b11571feac)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Apply suggestions from code review

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <[email protected]>

feat(ui): Add button for wrapping lines in pod logs viewer (#15506)

* Add back wrap log line button

Signed-off-by: Yi Cai <[email protected]>

* Fixed lint issue

Signed-off-by: Yi Cai <[email protected]>

* Updated icon and location of Wrap Lines btn

Signed-off-by: Yi Cai <[email protected]>

* Fixed lint issue

Signed-off-by: Yi Cai <[email protected]>

* Put back pre tag and Ansi component

Signed-off-by: Yi Cai <[email protected]>

---------

Signed-off-by: Yi Cai <[email protected]>

chore: add CODEOWNERS (#14693)

* chore: add CODEOWNERS

Signed-off-by: Michael Crenshaw <[email protected]>

* new owners

Signed-off-by: Michael Crenshaw <[email protected]>

* use teams

Signed-off-by: Michael Crenshaw <[email protected]>

* restore old owners file

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>

fix: reflect expected integers in swagger doc (#13046)

Signed-off-by: Michael Crenshaw <[email protected]>

chore(deps): bump oras.land/oras-go/v2 from 2.2.1 to 2.3.0 (#15549)

Bumps [oras.land/oras-go/v2](https://github.com/oras-project/oras-go) from 2.2.1 to 2.3.0.
- [Release notes](https://github.com/oras-project/oras-go/releases)
- [Commits](https://github.com/oras-project/oras-go/compare/v2.2.1...v2.3.0)

---
updated-dependencies:
- dependency-name: oras.land/oras-go/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump github.com/antonmedv/expr from 1.12.7 to 1.15.2 (#15548)

Bumps [github.com/antonmedv/expr](https://github.com/antonmedv/expr) from 1.12.7 to 1.15.2.
- [Release notes](https://github.com/antonmedv/expr/releases)
- [Commits](https://github.com/antonmedv/expr/compare/v1.12.7...v1.15.2)

---
updated-dependencies:
- dependency-name: github.com/antonmedv/expr
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix(repo-server): avoid fetching commit sha for multisource applications (#15037) (#15067)

* Rebase Signed-off-by: ozlevka-work <[email protected]>

Signed-off-by: Lev <[email protected]>

* Remove test file Signed-off-by: ozlevka-work <[email protected]>

Signed-off-by: Lev <[email protected]>

* Go linter fmt Signed-off-by: ozlevka-work <[email protected]>

Signed-off-by: Lev <[email protected]>

* Additional linter fmt Signed-off-by: ozlevka-work <[email protected]>

Signed-off-by: Lev <[email protected]>
Signed-off-by: Lev <[email protected]>

* Add unit test for changes Signed-off-by: Lev <[email protected]>

Signed-off-by: Lev <[email protected]>

* Update reposerver/repository/repository.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Lev Ozeryansky <[email protected]>
Signed-off-by: Lev <[email protected]>

* Trigger CI

Signed-off-by: Lev <[email protected]>

---------

Signed-off-by: Lev <[email protected]>
Signed-off-by: Lev <[email protected]>
Signed-off-by: Lev Ozeryansky <[email protected]>
Co-authored-by: Lev <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>

doc: adds vals-operator to secrets list (#11795)

Vals-Operator can also be used for managing secrets in Kubernetes.

Signed-off-by: Sergio Rua <[email protected]>

chore(deps): bump actions/cache from 3.3.1 to 3.3.2 (#15552)

Bumps [actions/cache](https://github.com/actions/cache) from 3.3.1 to 3.3.2.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8...704facf57e6136b1bc63b828d79edcd491f0ee84)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jannfis <[email protected]>

docs: better command reference titles (#15567) (#15568)

Signed-off-by: Michael Crenshaw <[email protected]>

chore(deps): bump library/node from 20.6.1 to 20.7.0 in /ui-test (#15583)

Bumps library/node from 20.6.1 to 20.7.0.

---
updated-dependencies:
- dependency-name: library/node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump library/node from 20.6.1 to 20.7.0 in /test/container (#15585)

Bumps library/node from 20.6.1 to 20.7.0.

---
updated-dependencies:
- dependency-name: library/node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: pasha-codefresh <[email protected]>

docs: Add documentation on how to specify shard number for a cluster in "high availibility" doc (#5348) (#13258)

Signed-off-by: Sridhar Nandigam <[email protected]>

docs: 'action' RBAC example for Kind without group (#15589)

chore: add gdsoumya to reviewers (#15596)

Signed-off-by: gdsoumya <[email protected]>

feat: added patch_ms and setop_ms timings to reconciliation logs (#15595)

* feat: added patch_ms to reconciliation logs

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

* feat: added patch_ms and setop_ms timings to logs

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

---------

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

Removed conflicting files

Signed-off-by: Gergely Czuczy <[email protected]>

chore(action): minor lua changes (#15580)

* chore(action): add newlines at eof

Signed-off-by: Josh Soref <[email protected]>

* chore(action): fix whitespace indentation

Signed-off-by: Josh Soref <[email protected]>

* chore(action): use local annotations

Signed-off-by: Josh Soref <[email protected]>

---------

Signed-off-by: Josh Soref <[email protected]>

chore(deps): bump library/golang from `cffaba7` to `2270a40` (#15615)

Signed-off-by: Michael Crenshaw <[email protected]>

feat(extensions): Automatically apply extension configs without restarting API-Server (#15574)

* feat: auto configure extensions

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* feat: auto-reload extension configs without restarting api-server

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* clean unused gorilla mux

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* update docs

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Address review comments

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Add more test cases

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* refactoring to reduce unnecessary function

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* Add log

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* fix bugs found during manual tests

Signed-off-by: Leonardo Luz Almeida <[email protected]>

---------

Signed-off-by: Leonardo Luz Almeida <[email protected]>

Update the supported version policy in Operator Manual Installation doc (#15619)

The supported version policy mentioned in the operator manual installation document diverges from the official policy that is mentioned in the security policy and the release cadence.

This change brings the version policy in line by referring the readers to the release and cadence documentation to check the specified policy.

Signed-off-by: Muhammad Mooneeb Hussain <[email protected]>

doc: resource tracking custom label configuration (#15587)

Signed-off-by: Timoses <[email protected]>

feat(cli): tree option in output flag for app sync, app wait and app rollback for tree view (#15572)

* app sync and app wait tree view changes

Signed-off-by: schakrad <[email protected]>

* documentation changes

Signed-off-by: schakrad <[email protected]>

* included the json,yaml and wide formats and removed the value assignment to the flag

Signed-off-by: schakrad <[email protected]>

* Reoved extra spaces

Signed-off-by: schakrad <[email protected]>

* removed extra spaces

Signed-off-by: schakrad <[email protected]>

* refactored the code

Signed-off-by: schakrad <[email protected]>

* better log statements

Signed-off-by: schakrad <[email protected]>

---------

Signed-off-by: schakrad <[email protected]>

feat: dynamic rebalancing of clusters across shards (#15036)

* Migrate Application Controller from Statefulset to Deployment

Signed-off-by: ishitasequeira <[email protected]>

* Add sharding deployment logic

Signed-off-by: ishitasequeira <[email protected]>

* Update sharding logic and add comments

Signed-off-by: ishitasequeira <[email protected]>

* Add heartbeat as an environment variable

Signed-off-by: ishitasequeira <[email protected]>

* Add retry logic, heartbeat timeout environment variable

Signed-off-by: ishitasequeira <[email protected]>

* use the logic of pre-specified shard number on application controller pod

Signed-off-by: ishitasequeira <[email protected]>

* fix manifests

Signed-off-by: ishitasequeira <[email protected]>

* fix lint and e2e tests

Signed-off-by: ishitasequeira <[email protected]>

* comment out failing e2e test

Signed-off-by: ishitasequeira <[email protected]>

* increase readiness probe interval period

Signed-off-by: ishitasequeira <[email protected]>

* "comment out readiness probe to see if e2e tests succeed"

Signed-off-by: ishitasequeira <[email protected]>

* revert commented readiness probe

Signed-off-by: ishitasequeira <[email protected]>

* revert commented test case

Signed-off-by: ishitasequeira <[email protected]>

* read environment variable for application controller deployment name

Signed-off-by: ishitasequeira <[email protected]>

* Add nil check on replica count for deployment of application controller

Signed-off-by: ishitasequeira <[email protected]>

* Address comments

Signed-off-by: ishitasequeira <[email protected]>

* Add Informer, Update documentation, add unit tests

Signed-off-by: ishitasequeira <[email protected]>

* update godoc

Signed-off-by: ishitasequeira <[email protected]>

* remove unwanted code and logs

Signed-off-by: ishitasequeira <[email protected]>

* Add more documentation

Signed-off-by: ishitasequeira <[email protected]>

* revert ApplicationController manifest to StatefulSet

Signed-off-by: ishitasequeira <[email protected]>

* reverting updated docs

Signed-off-by: ishitasequeira <[email protected]>

* Add documentation for the new dynamic distribution feature

Signed-off-by: ishitasequeira <[email protected]>

* update documentation

Signed-off-by: ishitasequeira <[email protected]>

* Add an overlay for application controller deployment and update documentation

Signed-off-by: ishitasequeira <[email protected]>

* fix nit

Signed-off-by: ishitasequeira <[email protected]>

* Marking the feature as alpha

Signed-off-by: ishitasequeira <[email protected]>

* Add feature status link

Signed-off-by: ishitasequeira <[email protected]>

* revert go,mod changes

Signed-off-by: ishitasequeira <[email protected]>

* update docs to avoid focusing on StatefulSet/Deployment (#26)

* update docs to avoid focusing on StatefulSet/Deployment

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>

* minor update to the doc

Signed-off-by: ishitasequeira <[email protected]>

---------

Signed-off-by: ishitasequeira <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>

chore(deps): bump node version (#15616)

* chore(deps): bump node version

Signed-off-by: Michael Crenshaw <[email protected]>

* fix version

Signed-off-by: Michael Crenshaw <[email protected]>

* update lockfile

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>

feat(appset): add Support for AzureDevops Webhooks (#15047)

Signed-off-by: Robin Lieb <[email protected]>

fix(cli): get latest app state before printing tree (#15639)

Signed-off-by: Michael Crenshaw <[email protected]>

chore(deps): bump actions/setup-node from 3.8.0 to 3.8.1 (#15108)

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.8.0 to 3.8.1.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](https://github.com/actions/setup-node/compare/bea5baf987ba7aa777a8a0b4ace377a21c45c381...5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Marquis <[email protected]>
Co-authored-by: pasha-codefresh <[email protected]>

feat(kustomize): add patches field (#5114) (#14648)

feat(health): Implement AnsibleJob CRD health checks (#14483)

Signed-off-by: Mike Ng <[email protected]>

feat(health): add PushSecret health status and force-sync action (#14375)

* feat(health): add `PushSecret` health status

Signed-off-by: Alexandre Gaudreault <[email protected]>

* add status healthy

Signed-off-by: Alexandre Gaudreault <[email protected]>

* Push action

Signed-off-by: Alexandre Gaudreault <[email protected]>

* fix test

Signed-off-by: Alexandre Gaudreault <[email protected]>

---------

Signed-off-by: Alexandre Gaudreault <[email protected]>

fix(kustomize): no concurrent processing if Kustomize patches are used (#15654)

Signed-off-by: Michael Crenshaw <[email protected]>

feat(appset): ignoreApplicationDifferences (#9101) (#14743)

* feat(appset): ignoreDifferences (#9101)

Signed-off-by: Michael Crenshaw <[email protected]>

* better error messages

Signed-off-by: Michael Crenshaw <[email protected]>

* do better

Signed-off-by: Michael Crenshaw <[email protected]>

* docs

Signed-off-by: Michael Crenshaw <[email protected]>

* more tests, update docs

Signed-off-by: Michael Crenshaw <[email protected]>

* e2e test

Signed-off-by: Michael Crenshaw <[email protected]>

* expect auto-added fields

Signed-off-by: Michael Crenshaw <[email protected]>

* correct label

Signed-off-by: Michael Crenshaw <[email protected]>

* better

Signed-off-by: Michael Crenshaw <[email protected]>

* remove line that was reverted

Signed-off-by: Michael Crenshaw <[email protected]>

* Update docs/operator-manual/applicationset.yaml

Signed-off-by: Michael Crenshaw <[email protected]>

* remove line that mysteriously causes applicationset/utils unit tests to fail

Signed-off-by: Michael Crenshaw <[email protected]>

* login to fix test

Signed-off-by: Michael Crenshaw <[email protected]>

* maybe this will work, who knows

Signed-off-by: Michael Crenshaw <[email protected]>

* burn it all down

Signed-off-by: Michael Crenshaw <[email protected]>

* works on my machine

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>

fix(applicationset): cannot validate inherited project permissions (#9298) (#15026)

* fix(applicationset): cannot validate inherited project permissions

Signed-off-by: Alexandre Gaudreault <[email protected]>

* update tests to reflect behavior

Signed-off-by: Alexandre Gaudreault <[email protected]>

---------

Signed-off-by: Alexandre Gaudreault <[email protected]>

chore(deps): bump semver from 5.7.1 to 5.7.2 in /ui-test (#14457)

Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](https://github.com/npm/node-semver/compare/v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(ci): free up disk space (#15674)

Signed-off-by: Michael Crenshaw <[email protected]>

fix: add a not found check for application controller deployment (#15678)

Signed-off-by: ishitasequeira <[email protected]>

[fix] sidebar style (#15652)

Signed-off-by: ymktmk <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>

fix(ci): free up disk space (#15683)

* fix(ci): free up disk space

Signed-off-by: Michael Crenshaw <[email protected]>

* Update .github/workflows/image-reuse.yaml

Co-authored-by: Justin Marquis <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>

* Update .github/workflows/image-reuse.yaml

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Justin Marquis <[email protected]>

fix(ci): do not fail fast on e2e test failures (#15694)

Signed-off-by: Michael Crenshaw <[email protected]>

fix(ci): misplaced config option (#15698)

Signed-off-by: Michael Crenshaw <[email protected]>

fix(applicationset): git generator ignores empty files (#15661)

Signed-off-by: Alexandre Gaudreault <[email protected]>

fix(appset): don't emit k8s events for unchanged apps, log at debug (#15659) (#15660)

* fix(appset): don't emit k8s events for unchanged application events and move that scenario to debug logging level

Signed-off-by: Eric Blackburn <[email protected]>

* Retrigger CI pipeline

Signed-off-by: Eric Blackburn <[email protected]>

* Retrigger CI pipeline

Signed-off-by: Eric Blackburn <[email protected]>

---------

Signed-off-by: Eric Blackburn <[email protected]>
Co-authored-by: Alexander Matyushentsev <[email protected]>

feat(ci): retry individual e2e tests (#15696)

docs: Maintaining Uniformity In Documentation Writing Style (#15713)

In the Projects section there are two words 'what' and 'where'  are written in italic(in the first two sentences) but in the third sentence 'what' is written in normal text. So i changed the two words written in italic to normal text to maintain the uniformity of writing style of documentation.
See this issue in the Projects section  : "https://argo-cd.readthedocs.io/en/stable/user-guide/projects/"

Signed-off-by: PranitRout07 <[email protected]>

docs: add dynamic cluster distribution doc in the menu (#15716)

Converted italic text to normal text (#15692)

To see the issue , go to this link "https://argo-cd.readthedocs.io/en/stable/operator-manual/app-any-namespace/"
In Prerequisites section ,the word 'not' is unnecessarily written in italic. It should be written in normal text to maintain the uniformity.

Signed-off-by: PranitRout07 <[email protected]>
Co-authored-by: Dan Garfield <[email protected]>

fix(action): populate all fields of Job from CronJob (#15259) (#15727)

Signed-off-by: sergey.ladutko <[email protected]>
Co-authored-by: sergey.ladutko <[email protected]>

fix(application-controller): Fix panic error when trying to scale application controller shards  (#15725)

* Added error checking to determine if application controller deployment is found or not

Signed-off-by: Anand Francis Joseph <[email protected]>

* Fixed the informer to list deployments in namespace scope

Signed-off-by: Anand Francis Joseph <[email protected]>

* Fixed readiness check probe for application controller when running as deployment

Signed-off-by: Anand Francis Joseph <[email protected]>

---------

Signed-off-by: Anand Francis Joseph <[email protected]>

docs: move self-signed certs gitlab scm docs (#15720)

fix: only enable dynamic cluster sharding feature explicitly (#15734)

* fix: only enable dynamic cluster sharding feature explicitly

Signed-off-by: Remington Breeze <[email protected]>

---------

Signed-off-by: Remington Breeze <[email protected]>

Fixed Custom Link Text not Hyperlinked (#15747)

Visit this link to see the issue : https://argo-cd.readthedocs.io/en/stable/developer-guide/ci/#public-cd

Signed-off-by: PranitRout07 <[email protected]>

docs: Add documentation for Zitadel SSO integration (#15029)

* Add zitadel documentation

Signed-off-by: Stephan Renggli <[email protected]>

* Add zitadel docs images

Signed-off-by: Stephan Renggli <[email protected]>

* Update zitadel.md

Signed-off-by: Stephan Renggli <[email protected]>

* Update docs/operator-manual/user-management/zitadel.md

Co-authored-by: Florian Forster <[email protected]>
Signed-off-by: Stephan Renggli <[email protected]>

* Update docs/operator-manual/user-management/zitadel.md

Co-authored-by: Florian Forster <[email protected]>
Signed-off-by: Stephan Renggli <[email protected]>

* Fix typos

Signed-off-by: Stephan Renggli <[email protected]>

* Apply suggestions from code review

Fix grammar issues

Co-authored-by: Dan Garfield <[email protected]>
Signed-off-by: Stephan Renggli <[email protected]>

* Add zitadel page to mkdocs.yml

Signed-off-by: Stephan Renggli <[email protected]>

---------

Signed-off-by: Stephan Renggli <[email protected]>
Co-authored-by: Florian Forster <[email protected]>
Co-authored-by: Dan Garfield <[email protected]>
Co-authored-by: pasha-codefresh <[email protected]>

chore: set proper struct tag for ApplicationSetTerminalGenerator.Plugin field (#15742)

Signed-off-by: chavacava <[email protected]>

test: bump k8s versions for e2e tests (#15766)

Signed-off-by: Michael Crenshaw <[email protected]>

docs: add Mercedes-Benz.io to user list (#15768)

Signed-off-by: Gonçalo Montalvão Marques <[email protected]>

chore: don't make argocd-approvers owners of anything (#15774)

Signed-off-by: Michael Crenshaw <[email protected]>

docs: add `CONTRIBUTING.md` copy at repo root (#14889)

* docs: add `CONTRIBUTING.md` symlink at repo root

- having a `CONTRIBUTING.md` at the root of the repo is a common convention
  - I looked at the root initially, didn't find it, then checked `docs/` and saw one there and then went to the website
    - but potential contributors may not realize this, so a symlink should help with discoverability

Signed-off-by: Anton Gilgur <[email protected]>

* change to cp instead of symlink per review

Signed-off-by: Anton Gilgur <[email protected]>

---------

Signed-off-by: Anton Gilgur <[email protected]>

chore: revert codeowners test change (#15777)

This reverts commit 173eb5b33c0248b2316fa064eba9ffa5379a24ba.

Signed-off-by: Michael Crenshaw <[email protected]>

fix: address nil pointer when controller runs with sts and replicas > 1 (#15770)

* fix: address nil pointer when controller runs with sts and replicas > 1

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* fix: lint

Signed-off-by: Leonardo Luz Almeida <[email protected]>

* fix: better handle errors

Signed-off-by: Leonardo Luz Almeida <[email protected]>

---------

Signed-off-by: Leonardo Luz Almeida <[email protected]>

chore: allow docs approvers to merge USERS.md changes (#15773)

Signed-off-by: Michael Crenshaw <[email protected]>

fix(plugin): remove git environment variables unavailable to plugin execution (#14998) (#15104)

* remove git creds environment variables unavailable to plugin execution

Signed-off-by: jmcshane <[email protected]>

* remove integration test asserting askpass is forwarded

Signed-off-by: jmcshane <[email protected]>

---------

Signed-off-by: jmcshane <[email protected]>

fix(ui): responsive topbar, filter button in application details page (#11188) (#15789)

Signed-off-by: Julien Fuix <[email protected]>
Co-authored-by: Julien Fuix <[email protected]>

chore(cli): clarify core mode code (#15800)

* chore(cli): clarify core mode code

Signed-off-by: Michael Crenshaw <[email protected]>

* rename function

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>

chore: Add SCRM Lidl International Hub as users (#15801)

Signed-off-by: Jorge Turrado <[email protected]>

docs: fix list format (#15798)

Signed-off-by: Michael Crenshaw <[email protected]>

fix(appset): add option to disable SCM providers entirely (#14246) (#15248)

* feat(appset): add option to disable SCM providers entirely (#14246)

Signed-off-by: Michael Crenshaw <[email protected]>

* clarify docs

Signed-off-by: Michael Crenshaw <[email protected]>

* more clarification, small refactor

Signed-off-by: Michael Crenshaw <[email protected]>

* more clarification

Signed-off-by: Michael Crenshaw <[email protected]>

* fix test

Signed-off-by: Michael Crenshaw <[email protected]>

* refactor

Signed-off-by: Michael Crenshaw <[email protected]>

* fix test assertion

Signed-off-by: Michael Crenshaw <[email protected]>

* simplify test expectation

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>

fea(cli)t: Add example to --help output for "argocd appset get" (#15808)

Signed-off-by: Michele Caci <[email protected]>

fix: codeowners syntax error (#15781)

Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>

fix(cli): Do not error out with no errors (#15688)

test(e2e): do not always include plaintext for account update password (#15665)

Signed-off-by: Chris Fry <[email protected]>

test(e2e): update git submodule remote tests to use submodule url (#15701)

Signed-off-by: Chris Fry <[email protected]>

docs: actually all helm hooks are ignored (#15752)

* docs: actually all helm hooks are ignored

Signed-off-by: naruse666 <[email protected]>

* fix: add "All of"

Signed-off-by: naruse666 <[email protected]>

* Update docs/user-guide/helm.md

Co-authored-by: Blake Pettersson <[email protected]>
Signed-off-by: naruse <[email protected]>

---------

Signed-off-by: naruse666 <[email protected]>
Signed-off-by: naruse <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>

feat(cli): Added example to --help output for context  (#15809)

* docs: fix list format (#15798)

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: sagarwala1 <[email protected]>

* fix(appset): add option to disable SCM providers entirely (#14246) (#15248)

* feat(appset): add option to disable SCM providers entirely (#14246)

Signed-off-by: Michael Crenshaw <[email protected]>

* clarify docs

Signed-off-by: Michael Crenshaw <[email protected]>

* more clarification, small refactor

Signed-off-by: Michael Crenshaw <[email protected]>

* more clarification

Signed-off-by: Michael Crenshaw <[email protected]>

* fix test

Signed-off-by: Michael Crenshaw <[email protected]>

* refactor

Signed-off-by: Michael Crenshaw <[email protected]>

* fix test assertion

Signed-off-by: Michael Crenshaw <[email protected]>

* simplify test expectation

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>
Signed-off-by: sagarwala1 <[email protected]>

* add context example to help

Signed-off-by: sagarwala1 <[email protected]>

* add context example to help Signed-off-by: sagarwala

Signed-off-by: sagarwala1 <[email protected]>

* fea(cli)t: Add example to --help output for "argocd appset get" (#15808)

Signed-off-by: Michele Caci <[email protected]>
Signed-off-by: sagarwala1 <[email protected]>

* fix: codeowners syntax error (#15781)

Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>
Signed-off-by: sagarwala1 <[email protected]>

* Trigger checks again Signed-off-by: sagarwala1 <[email protected]>

Signed-off-by: sagarwala1 <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: sagarwala1 <[email protected]>
Signed-off-by: Michele Caci <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>
Co-authored-by: Michele Caci <[email protected]>

chore(ci): fix generate code CI failure (#15828)

Signed-off-by: jmcshane <[email protected]>

feat(cli): Add example to `--help` output 1 (#15782)

* re-sign commit with DCO

Signed-off-by: Dao Thanh Tung <[email protected]>

* Update doc file

Signed-off-by: Dao Thanh Tung <[email protected]>

---------

Signed-off-by: Dao Thanh Tung <[email protected]>

test(e2e): always specify master as the initial git branch (#15662)

Signed-off-by: Chris Fry <[email protected]>

feat(cli): Add examples to --help output for remaining "argocd repocreds" cmds (#15846)

Signed-off-by: Michele Caci <[email protected]>

feat(cli): Add examples to --help output for remaining "argocd account" (#15814)

* feat: Add examples to --help output for remaining "argocd account"

Signed-off-by: Michele Caci <[email protected]>

* Update cmd/argocd/commands/account.go

Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michele Caci <[email protected]>

---------

Signed-off-by: Michele Caci <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>

feat(cli): Add example to --help output for app actions (#15822)

Signed-off-by: kokikathir <[email protected]>

feat(appset): fromYaml, fromYamlArray toYaml functions (#15063)

* feat(appset): fromYaml, fromYamlArray toYaml functions

Signed-off-by: Geoffrey Muselli <[email protected]>

* fix(11993): Document and error messages

Signed-off-by: gmuselli <[email protected]>

---------

Signed-off-by: Geoffrey Muselli <[email protected]>
Signed-off-by: gmuselli <[email protected]>

chore: skip server certificate verification for http requests in e2e tests (#15733)

* chore: skip verifying server certificate for http requests in e2e tests

Signed-off-by: Chris Fry <[email protected]>

* chore: skip certificate verification only for remote tests

Signed-off-by: Chris Fry <[email protected]>

---------

Signed-off-by: Chris Fry <[email protected]>

docs: improve notifications docs (#15816)

* docs: improve notifications docs

Signed-off-by: Michael Crenshaw <[email protected]>

* use a version compatible with Python 3.7, which is what RTD runs

Signed-off-by: Michael Crenshaw <[email protected]>

* more fixes

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>

fix(notifications): Allow notifications controller to notify on all namespaces (#15702)

* Allow notifications controller to notify on all namespaces

This adds functionality to the notifications controller to be notified
of and send notifications for applications in any namespace. The
namespaces to watch are controlled by the same --application-namespaces
and ARGOCD_APPLICATION_NAMESPACES variables as in the application
controller.

Signed-off-by: Nikolas Skoufis <[email protected]>

* Add SEEK to users.md

Signed-off-by: Nikolas Skoufis <[email protected]>

* Remove unused fields

Signed-off-by: Nikolas Skoufis <[email protected]>

* Revert changes to Procfile

Signed-off-by: Nik Skoufis <[email protected]>

* Fix unit tests

Signed-off-by: Nikolas Skoufis <[email protected]>

* - add argocd namespaces environment variable to notifications controller

Signed-off-by: Stewart Thomson <[email protected]>

* - add example cluster role rbac

Signed-off-by: Stewart Thomson <[email protected]>

* - only look for projects in the controller's namespace (argocd by default)

Signed-off-by: Stewart Thomson <[email protected]>

* - update base manifest

Signed-off-by: Stewart Thomson <[email protected]>

* - skip app processing in notification controller

Signed-off-by: Stewart Thomson <[email protected]>

* added unit test and updated doc

Signed-off-by: May Zhang <[email protected]>

* added unit test and updated doc

Signed-off-by: May Zhang <[email protected]>

* updated examples/k8s-rbac/argocd-server-applications/kustomization.yaml's resources

Signed-off-by: May Zhang <[email protected]>

---------

Signed-off-by: Nikolas Skoufis <[email protected]>
Signed-off-by: Nik Skoufis <[email protected]>
Signed-off-by: Stewart Thomson <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Co-authored-by: Nikolas Skoufis <[email protected]>
Co-authored-by: Nik Skoufis <[email protected]>
Co-authored-by: Stewart Thomson <[email protected]>

chore: log more fields with error (#15735)

Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>

feat(cli): Added example to --help output for bcrypt (#15838)

* feat: Added example to --help output for bcrypt

Signed-off-by: abalaraj <[email protected]>

* feat: Added example to --help output for bcrypt

Signed-off-by: abalaraj <[email protected]>

---------

Signed-off-by: abalaraj <[email protected]>

feat: Add examples to --help output for all "argocd proj" cmds (#15824)

Signed-off-by: Michele Caci <[email protected]>

chore(deps): bump gitops-engine (#15736)

* chore(deps): bump gitops-engine

Signed-off-by: Michael Crenshaw <[email protected]>

* go mod tidy

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>

feat(cli): Add example to argocd relogin command (#15839)

* feat: Add example to argocd relogin command

Signed-off-by: Chiranjeevi R <[email protected]>

* feat: Add example to argocd relogin command

Signed-off-by: Chiranjeevi R <[email protected]>

* correc --sso flag

Signed-off-by: Chiranjeevi R <[email protected]>

* Apply suggestions from code review

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Chiranjeevi R <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>

test(e2e): allow build of argocd-e2e-cluster image for remote tests (#15805)

* chore: allow build of argocd-e2e-cluster image for remote testing

Signed-off-by: Chris Fry <[email protected]>

* Retrigger CI pipeline

Signed-off-by: Chris Fry <[email protected]>

---------

Signed-off-by: Chris Fry <[email protected]>

docs: clarify health inheritance (#15799)

* docs: resource health inheritance

Signed-off-by: Michael Crenshaw <[email protected]>

* write more better

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>

fix: Replace antonmedv/expr with expr-lang/expr (#15879)

feat(cli): Add examples to --help output for "logs APPNAME" (#15873)

* feat: Add examples to --help output for logs APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* feat: Add examples to --help output for logs APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

---------

Signed-off-by: Ratan Gulati <[email protected]>

feat(cli): Add examples to --help output for "set APPNAME" (#15872)

* feat: Add examples to --help output for get APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

* feat: Add examples to --help output for get APPNAME

Signed-off-by: Ratan Gulati <[email protected]>

---------

Signed-off-by: Ratan Gu…
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
Signed-off-by: Marcelo Moreira de Mello <[email protected]>
Co-authored-by: Nicholas Morey <[email protected]>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Signed-off-by: Marcelo Moreira de Mello <[email protected]>
Co-authored-by: Nicholas Morey <[email protected]>
lukaszgyg pushed a commit to lukaszgyg/argo-cd that referenced this pull request Jan 12, 2024
Signed-off-by: Marcelo Moreira de Mello <[email protected]>
Co-authored-by: Nicholas Morey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

v2.8.2 raw manifests install method is missing jobs RBACs
5 participants