Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PerconaXtraDBCluster healthcheck (#16396) #16434

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix: PerconaXtraDBCluster healthcheck (#16396) #16434

merged 1 commit into from
Nov 30, 2023

Conversation

filiprafaj
Copy link
Contributor

@filiprafaj filiprafaj commented Nov 23, 2023 •
edited
Loading

The healthcheck for pxc.percona.com/PerconaXtraDBCluster fails when the cluster is in error state throwing
<string>:30: bad argument #1 to concat (table expected, got nil)

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
    Fixes PerconaXtraDBCluster healthcheck fails when error state #16396
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@filiprafaj filiprafaj requested a review from a team as a code owner November 23, 2023 13:10
@codecov Codecov
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ccdc453) 49.55% compared to head (bbacce8) 49.53%.
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #16434      +/-   ##
==========================================
- Coverage   49.55%   49.53%   -0.02%     
==========================================
  Files         269      269              
  Lines       47046    47222     +176     
==========================================
+ Hits        23313    23392      +79     
- Misses      21445    21530      +85     
- Partials     2288     2300      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ishitasequeira
ishitasequeira approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Thanks @filiprafaj

@ishitasequeira ishitasequeira merged commit c602302 into argoproj:master Nov 30, 2023
26 checks passed
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
@filiprafaj @vladfr
fix PerconaXtraDBCluster health (argoproj#16434)
788d788 
Signed-off-by: Filip Rafaj <[email protected]>
Co-authored-by: Filip Rafaj <[email protected]>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@filiprafaj @tesla59
fix PerconaXtraDBCluster health (argoproj#16434)
05ba67c 
Signed-off-by: Filip Rafaj <[email protected]>
Co-authored-by: Filip Rafaj <[email protected]>
JulienFuix pushed a commit to JulienFuix/argo-cd that referenced this pull request Feb 6, 2024
@filiprafaj
fix PerconaXtraDBCluster health (argoproj#16434)
e1f9b79 
Signed-off-by: Filip Rafaj <[email protected]>
Co-authored-by: Filip Rafaj <[email protected]>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@filiprafaj @lyda
fix PerconaXtraDBCluster health (argoproj#16434)
2aad99a 
Signed-off-by: Filip Rafaj <[email protected]>
Co-authored-by: Filip Rafaj <[email protected]>
Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@filiprafaj @Hariharasuthan99
fix PerconaXtraDBCluster health (argoproj#16434)
f04e6bb 
Signed-off-by: Filip Rafaj <[email protected]>
Co-authored-by: Filip Rafaj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PerconaXtraDBCluster healthcheck fails when error state
2 participants
@filiprafaj @ishitasequeira