Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): allow disabling content-type check (#16959) (2.10) #16976

Conversation

crenshaw-dev
Copy link
Member

  • fix(server): allow disabling content-type check

  • fix spacing


Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

* fix(server): allow disabling content-type check

Signed-off-by: Michael Crenshaw <[email protected]>

* fix spacing

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
@crenshaw-dev crenshaw-dev requested review from a team as code owners January 24, 2024 21:15
@crenshaw-dev crenshaw-dev changed the title fix(server): allow disabling content-type check (#16959) fix(server): allow disabling content-type check (#16959) (2.10) Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b657e97) 49.33% compared to head (e246b37) 49.35%.

Files Patch % Lines
server/server.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-2.10   #16976      +/-   ##
================================================
+ Coverage         49.33%   49.35%   +0.01%     
================================================
  Files               272      272              
  Lines             47888    47890       +2     
================================================
+ Hits              23625    23635      +10     
+ Misses            21930    21920      -10     
- Partials           2333     2335       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishitasequeira ishitasequeira merged commit a848105 into argoproj:release-2.10 Jan 24, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants