Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UI MultiSource - Helm Chart with values.yaml (#18188) #18200

Conversation

keithchong
Copy link
Contributor

@keithchong keithchong commented May 13, 2024

Fixes #18188

This will show the sync status info for single source apps as well as for the first source of the multiple source application. This will align with what is currently supported in the UI where only the first source is shown in the details panels of the application. The other option that is much simpler is to not show this panel at all for any multi-source app. This is to add !hasMultipleSource && on line 110 just before application.status &&

However, the status info might still be helpful, so I opted for this fix instead.

We want to fix this against 2.11 because we don't want the UI to blow up like what the issue reporter has encountered.

More complete support of this will be part of the changes delivered by the enhancement proposal to support multi-source applications in the UI.

Specifically, this #14124 and my follow-on changes should cover this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@keithchong keithchong requested a review from a team as a code owner May 13, 2024 17:55
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keithchong keithchong force-pushed the 18188-UIErrorWithMultipleSources branch from 9453dd1 to 3199039 Compare May 13, 2024 20:46
@keithchong keithchong force-pushed the 18188-UIErrorWithMultipleSources branch from 3199039 to f97cd6b Compare May 13, 2024 20:53
@ishitasequeira ishitasequeira merged commit 6530c6f into argoproj:release-2.11 May 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants