Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Improve the FAQ (#12039) #18645

Merged
merged 5 commits into from
Jun 14, 2024
Merged

docs: Improve the FAQ (#12039) #18645

merged 5 commits into from
Jun 14, 2024

Conversation

jsoref
Copy link
Member

@jsoref jsoref commented Jun 13, 2024 •
edited
Loading

Fixes #12039

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@jsoref jsoref requested review from a team as code owners June 13, 2024 21:40
jsoref
jsoref commented Jun 13, 2024
View reviewed changes
docs/faq.md Outdated Show resolved Hide resolved
@jsoref jsoref changed the title Improve the FAQ (#12039) docs: Improve the FAQ (#12039) Jun 13, 2024
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) June 14, 2024 13:28
@crenshaw-dev crenshaw-dev merged commit 48eb7f3 into argoproj:master Jun 14, 2024
23 checks passed
@jsoref jsoref deleted the faq branch June 14, 2024 14:30
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@jsoref @Hariharasuthan99
docs: Improve the FAQ (argoproj#12039) (argoproj#18645)
c76f4f4 
* docs: Fix whitespace around after open paren in FAQ

Signed-off-by: Josh Soref <[email protected]>

* docs: Fix trailing whitespace

Signed-off-by: Josh Soref <[email protected]>

* docs: Fix grammar in FAQ wrt redis auth

Signed-off-by: Josh Soref <[email protected]>

* docs: Fix FAQ markdown for turning off redis auth

Signed-off-by: Josh Soref <[email protected]>

* docs: Start talking about manifest generation

Signed-off-by: Josh Soref <[email protected]>

---------

Signed-off-by: Josh Soref <[email protected]>
ggjulio pushed a commit to ggjulio/argo-cd that referenced this pull request Jul 21, 2024
@jsoref @ggjulio
docs: Improve the FAQ (argoproj#12039) (argoproj#18645)
99a2224 
* docs: Fix whitespace around after open paren in FAQ

Signed-off-by: Josh Soref <[email protected]>

* docs: Fix trailing whitespace

Signed-off-by: Josh Soref <[email protected]>

* docs: Fix grammar in FAQ wrt redis auth

Signed-off-by: Josh Soref <[email protected]>

* docs: Fix FAQ markdown for turning off redis auth

Signed-off-by: Josh Soref <[email protected]>

* docs: Start talking about manifest generation

Signed-off-by: Josh Soref <[email protected]>

---------

Signed-off-by: Josh Soref <[email protected]>
jsolana pushed a commit to jsolana/argo-cd that referenced this pull request Jul 24, 2024
@jsoref
docs: Improve the FAQ (argoproj#12039) (argoproj#18645)
50e0ea9 
* docs: Fix whitespace around after open paren in FAQ

Signed-off-by: Josh Soref <[email protected]>

* docs: Fix trailing whitespace

Signed-off-by: Josh Soref <[email protected]>

* docs: Fix grammar in FAQ wrt redis auth

Signed-off-by: Josh Soref <[email protected]>

* docs: Fix FAQ markdown for turning off redis auth

Signed-off-by: Josh Soref <[email protected]>

* docs: Start talking about manifest generation

Signed-off-by: Josh Soref <[email protected]>

---------

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Javier Solana <[email protected]>
Signed-off-by: Javier Solana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs should cover how to respond to Manifest generation error (cached)
2 participants
@jsoref @crenshaw-dev