Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add graceful shutdown handling in notification for Issue#18642 #19368

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

D0ri123
Copy link
Contributor

@D0ri123 D0ri123 commented Aug 4, 2024

Partially fix : #18642

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@D0ri123 D0ri123 requested a review from a team as a code owner August 4, 2024 04:48
Copy link

bunnyshell bot commented Aug 4, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Aug 4, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@D0ri123 D0ri123 changed the title feat: Add graceful shutdown handling in notification feat: Add graceful shutdown handling in notification for Issue#18642 Aug 4, 2024
Copy link

codecov bot commented Aug 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 52.77%. Comparing base (f110570) to head (8c73ffe).
Report is 216 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd-notification/commands/controller.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19368      +/-   ##
==========================================
- Coverage   52.79%   52.77%   -0.03%     
==========================================
  Files         316      316              
  Lines       43602    43612      +10     
==========================================
- Hits        23021    23015       -6     
- Misses      18028    18042      +14     
- Partials     2553     2555       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@D0ri123
Copy link
Contributor Author

D0ri123 commented Aug 24, 2024

@jannfis PTAL

@D0ri123
Copy link
Contributor Author

D0ri123 commented Aug 25, 2024

@ishitasequeira PTAL

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @D0ri123 !! LGTM!!

@ishitasequeira ishitasequeira merged commit c4709fb into argoproj:master Sep 12, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement graceful shutdown in all Argo CD components
2 participants