-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add graceful shutdown handling in notification for Issue#18642 #19368
Conversation
Signed-off-by: LeeSeolHui <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19368 +/- ##
==========================================
- Coverage 52.79% 52.77% -0.03%
==========================================
Files 316 316
Lines 43602 43612 +10
==========================================
- Hits 23021 23015 -6
- Misses 18028 18042 +14
- Partials 2553 2555 +2 ☔ View full report in Codecov by Sentry. |
@jannfis PTAL |
@ishitasequeira PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @D0ri123 !! LGTM!!
Partially fix : #18642
Checklist: