fix: prevent crash during timer expiration after stream is closed #19917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
morapet
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19917 +/- ##
==========================================
- Coverage 55.83% 55.83% -0.01%
==========================================
Files 320 320
Lines 44381 44381
==========================================
- Hits 24782 24781 -1
- Misses 17030 17041 +11
+ Partials 2569 2559 -10 ☔ View full report in Codecov by Sentry. |
morapet
force-pushed
the
fix-logs-panic
branch
from
faec55d
to
c8e93f1
Compare
nitishfy
suggested changes
Sep 16, 2024
morapet
force-pushed
the
fix-logs-panic
branch
2 times, most recently
from
a02d12c
to
ae78498
Compare
Reorder ticker stop and close merge to prevent send(true) happens after merge is closed, in rare situation when the timer expires exactly at the point between close(merge) and ticker.Stop() Signed-off-by: morapet <[email protected]>
morapet
force-pushed
the
fix-logs-panic
branch
from
ae78498
to
ab221c3
Compare
|
/cherry-pick release-2.13 |
1 similar comment
|
/cherry-pick release-2.13 |
|
last try! I'll do it manually :( |
agaudreault
pushed a commit
to agaudreault/argo-cd
that referenced
this pull request
Oct 7, 2024
…j#19917) Reorder ticker stop and close merge to prevent send(true) happens after merge is closed, in rare situation when the timer expires exactly at the point between close(merge) and ticker.Stop() Signed-off-by: morapet <[email protected]>
agaudreault
pushed a commit
to agaudreault/argo-cd
that referenced
this pull request
Oct 7, 2024
…j#19917) Reorder ticker stop and close merge to prevent send(true) happens after merge is closed, in rare situation when the timer expires exactly at the point between close(merge) and ticker.Stop() Signed-off-by: morapet <[email protected]>
crenshaw-dev
pushed a commit
that referenced
this pull request
Oct 7, 2024
…#20272) Reorder ticker stop and close merge to prevent send(true) happens after merge is closed, in rare situation when the timer expires exactly at the point between close(merge) and ticker.Stop() Signed-off-by: morapet <[email protected]> Co-authored-by: morapet <[email protected]>
crenshaw-dev
pushed a commit
that referenced
this pull request
Oct 7, 2024
…9917) (#20271) Reorder ticker stop and close merge to prevent send(true) happens after merge is closed, in rare situation when the timer expires exactly at the point between close(merge) and ticker.Stop() Signed-off-by: morapet <[email protected]> Co-authored-by: morapet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorder ticker stop and close merge to prevent send(true) happens after merge is closed, in rare situation when the timer expires exactly at the point between close(merge) and ticker.Stop()
Checklist:
This is a bug
Closes #7006