fix(appset): Fix perpetual appset reconciliation (cherry-pick #19822) #19995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
Golang maps do not guarantee the order of the application resources from the applicationset which causes rapid sync activity for the applicationset as the objects and hence their resourceVersions are updated after each reconcile loop. This then triggers reconciliation of all objects watching the ApplicationSet. In order to prevent this behaviour, ensure that the ApplicationSet reconciler provides an idempotent list of resources, ensuring objects are not updated. Fixes: #19757 Signed-off-by: Thibault Jamet <[email protected]> Signed-off-by: Fabián Sellés <[email protected]> Co-authored-by: Fabian Selles <[email protected]> Co-authored-by: Ariadna Rouco <[email protected]>
agaudreault
approved these changes
Sep 19, 2024
gdsoumya
approved these changes
Sep 19, 2024
|
@gdsoumya did you create a follow-up PR to fix the failing unit tests? I was gonna do that today. |
|
@agaudreault I think it's safe to merge these cherry pick PRs, as far as I know often the tests keep failing for cherry pick PRs #19570 (comment) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix(appset): Fix perpetual appset reconciliation (#19822)
Golang maps do not guarantee the order of the application resources
from the applicationset which causes rapid sync activity for the applicationset
as the objects and hence their resourceVersions are updated after each reconcile loop.
This then triggers reconciliation of all objects watching the
ApplicationSet.
In order to prevent this behaviour, ensure that the ApplicationSet
reconciler provides an idempotent list of resources, ensuring objects
are not updated.
Fixes: #19757
Signed-off-by: Thibault Jamet [email protected]
Signed-off-by: Fabián Sellés [email protected]
Co-authored-by: Fabian Selles [email protected]
Co-authored-by: Ariadna Rouco [email protected]