-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hydrator): write credentials handling + UI #20166
Draft
crenshaw-dev
wants to merge
2
commits into
hydrator-controller-changes
Choose a base branch
from
hydrator-ui
base: hydrator-controller-changes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crenshaw-dev
force-pushed
the
hydrator-controller-changes
branch
from
October 1, 2024 17:14
b642ed7
to
1168d9d
Compare
crenshaw-dev
force-pushed
the
hydrator-ui
branch
from
October 1, 2024 17:15
41bc547
to
b111724
Compare
crenshaw-dev
force-pushed
the
hydrator-controller-changes
branch
from
October 11, 2024 15:19
f5e91ef
to
40cdcf2
Compare
crenshaw-dev
force-pushed
the
hydrator-ui
branch
2 times, most recently
from
October 11, 2024 16:35
f20b541
to
c23b5c6
Compare
crenshaw-dev
force-pushed
the
hydrator-controller-changes
branch
from
October 11, 2024 23:19
40cdcf2
to
d4fb401
Compare
crenshaw-dev
force-pushed
the
hydrator-ui
branch
from
October 11, 2024 23:30
c23b5c6
to
74686e6
Compare
crenshaw-dev
force-pushed
the
hydrator-controller-changes
branch
from
October 17, 2024 21:26
d4fb401
to
89bfa36
Compare
crenshaw-dev
force-pushed
the
hydrator-ui
branch
from
October 18, 2024 13:55
937923a
to
8ced464
Compare
crenshaw-dev
force-pushed
the
hydrator-controller-changes
branch
from
October 18, 2024 13:58
89bfa36
to
ad02bb4
Compare
crenshaw-dev
force-pushed
the
hydrator-ui
branch
2 times, most recently
from
October 20, 2024 18:33
d4d24a1
to
c67f923
Compare
crenshaw-dev
force-pushed
the
hydrator-controller-changes
branch
from
October 25, 2024 02:37
ad02bb4
to
619f45c
Compare
crenshaw-dev
force-pushed
the
hydrator-ui
branch
from
October 25, 2024 02:38
c67f923
to
2f2279f
Compare
crenshaw-dev
force-pushed
the
hydrator-controller-changes
branch
from
October 25, 2024 02:47
619f45c
to
3640971
Compare
crenshaw-dev
force-pushed
the
hydrator-ui
branch
from
October 25, 2024 02:47
2f2279f
to
23e5f5b
Compare
crenshaw-dev
force-pushed
the
hydrator-controller-changes
branch
from
October 30, 2024 20:06
3640971
to
ccc9e4b
Compare
crenshaw-dev
force-pushed
the
hydrator-ui
branch
from
October 30, 2024 20:08
23e5f5b
to
7b705b6
Compare
crenshaw-dev
force-pushed
the
hydrator-controller-changes
branch
from
October 31, 2024 21:21
ccc9e4b
to
d1e0886
Compare
crenshaw-dev
force-pushed
the
hydrator-ui
branch
from
October 31, 2024 21:21
7b705b6
to
d37f8df
Compare
crenshaw-dev
force-pushed
the
hydrator-controller-changes
branch
from
October 31, 2024 22:20
d1e0886
to
d233aad
Compare
Co-authored-by: Alexandre Gaudreault <[email protected]> Co-authored-by: Omer Azmon <[email protected]> Co-authored-by: daengdaengLee <[email protected]> Co-authored-by: Juwon Hwang (Kevin) <[email protected]> Co-authored-by: thisishwan2 <[email protected]> Co-authored-by: mirageoasis <[email protected]> Co-authored-by: Robin Lieb <[email protected]> Co-authored-by: miiiinju1 <[email protected]> Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: Michael Crenshaw <[email protected]> WIP: add new APIs for write creds Signed-off-by: Michael Crenshaw <[email protected]> write api and template api Signed-off-by: Michael Crenshaw <[email protected]> fix time function Signed-off-by: Michael Crenshaw <[email protected]> fix lint issues Signed-off-by: Michael Crenshaw <[email protected]> don't enrich with read creds Signed-off-by: Michael Crenshaw <[email protected]>
crenshaw-dev
force-pushed
the
hydrator-ui
branch
from
October 31, 2024 22:28
d37f8df
to
81b654e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is currently a hacky mess.
But it provides basic write credential handling (UI and backend) and a basic UI for the hydrator, built into the application view.