Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix false positive in plugin application discovery #20196

Merged
merged 3 commits into from
Oct 3, 2024
Merged

fix: Fix false positive in plugin application discovery #20196

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7278b9b
fix: fix false positive in plugin application discovery
pradithya Oct 2, 2024
70b3b0e
Merge branch 'master' into fix_20195
pradithya Oct 2, 2024
3f3aec7
fix: apply suggestion to return immediately if discovery is not confi…
pradithya Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion util/app/discovery/discovery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ func cmpSupports(ctx context.Context, pluginSockFilePath, appPath, repoPath, fil
}

// if discovery is not configured, return the client without further checks
if !cfg.IsDiscoveryConfigured {
if !cfg.IsDiscoveryConfigured && namedPlugin {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if !cfg.IsDiscoveryConfigured && namedPlugin {
if !cfg.IsDiscoveryConfigured && namedPlugin {

curious to know why aren't we using !namedPlugin here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we want to return the plugin if it's named directly.

return conn, cmpClient, true
}
crenshaw-dev marked this conversation as resolved.
Show resolved Hide resolved

Expand Down