Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct typos in authz-authn.md and proxy-extensions.md #20391

Merged
merged 2 commits into from
Oct 15, 2024
Merged

docs: correct typos in authz-authn.md and proxy-extensions.md #20391

merged 2 commits into from
Oct 15, 2024

Conversation

cowboysj
Copy link
Contributor

@cowboysj cowboysj commented Oct 15, 2024 •
edited
Loading

Description

This PR corrects two typos in authz-authn.md and proxy-extensions.md.

  1. "bellow" to "below" in "authz-authn.md".
  2. "modifiying" to "modifying" in "proxy-extensions.md".

Related Issue

Closes [ISSUE #20390]

Reason for Change

The typo can cause confusion for readers, and this fix improves the overall quality of the document.

before after
image image
image image

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@cowboysj cowboysj requested review from a team as code owners October 15, 2024 21:32
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 15, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@cowboysj cowboysj changed the title docs : correct typo from "bellow" to "below" in authz-authn.md docs: correct typo from "bellow" to "below" in authz-authn.md Oct 15, 2024
@cowboysj cowboysj changed the title docs: correct typo from "bellow" to "below" in authz-authn.md docs: correct typos in authz-authn.md and proxy-extensions.md Oct 15, 2024
@blakepettersson blakepettersson merged commit 049ba0a into argoproj:master Oct 15, 2024
26 checks passed
@blakepettersson
Copy link
Member

Thanks!

austin5219 pushed a commit to austin5219/argo-cd that referenced this pull request Oct 16, 2024
@cowboysj @austin5219
docs: correct typos in authz-authn.md and proxy-extensions.md (argopr…
6986047 
…oj#20391)

* docs : correct typo from "bellow" to "below" in authz-authn.md

Signed-off-by: Sujin Kim <[email protected]>

* docs : correct typo from "modifiying" to "modifying" in extensions.md

Signed-off-by: Sujin Kim <[email protected]>

---------

Signed-off-by: Sujin Kim <[email protected]>
Signed-off-by: austin5219 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakepettersson blakepettersson blakepettersson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cowboysj @blakepettersson