Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CVE-2024-43799 upgrade express to 4.21.0 to avoid [email protected] #20400

Merged

Conversation

nmirasch
Copy link

This PR fixes CVE-2024-43799 by upgrading the indirect dependency webpack-dev-server/express from 4.20.0 to 4.21.0 to avoid [email protected] that include the vulnerability related with "passing untrusted user input - even after sanitizing it - to SendStream.redirect() may execute untrusted code"

Before the change:

~/github/argo-cd/ui> npm ls send
[email protected] /home/nmirasch/gitOps/github/forks/argo-cd/ui
└─┬ [email protected]
  └─┬ [email protected]
    ├── [email protected]
    └─┬ [email protected]
      └── [email protected]

After:

~/github/argo-cd/ui> npm ls send
[email protected] /home/nmirasch/github/argo-cd/ui
└─┬ [email protected]
  └─┬ [email protected]
    ├── [email protected]
    └─┬ [email protected]
      └── [email protected] deduped

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@nmirasch nmirasch requested a review from a team as a code owner October 16, 2024 09:18
@nmirasch nmirasch force-pushed the GITOPS-5545_release-2.10 branch 2 times, most recently from b4e80ae to e317622 Compare October 16, 2024 10:35
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ishitasequeira ishitasequeira merged commit a3e2359 into argoproj:release-2.10 Oct 16, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants