Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add orphaned resource count metric #6391 #20521

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaehanbyun
Copy link
Contributor

Closes: #6391

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

What I have done:

For issue #6391, I have added a metric that indicates the count of orphaned resources for each application. This new metric is called argocd_app_orphaned_resources_count{label...} and tracks the number of orphaned resources per application.

Metric Output:

스크린샷 2024-10-24 오후 7 07 23

@jaehanbyun jaehanbyun requested a review from a team as a code owner October 24, 2024 10:10
Copy link

bunnyshell bot commented Oct 24, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jaehanbyun !! The overall change looks good!!

@ishitasequeira ishitasequeira enabled auto-merge (squash) October 24, 2024 12:04
@jaehanbyun
Copy link
Contributor Author

Hi @ishitasequeira, Auto merge did not execute properly. Could you please check?
Thanks!

@ishitasequeira
Copy link
Member

Hi @ishitasequeira, Auto merge did not execute properly. Could you please check?

Thanks!

Looks like the tests failed. I will try rerunning the tests.

@jaehanbyun
Copy link
Contributor Author

Hello @ishitasequeira,

Could you please rerun the tests when you have a moment? Let me know if you need anything else. Thank you!

auto-merge was automatically disabled October 30, 2024 11:21

Head branch was pushed to by a user without write access

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@ea46572). Learn more about missing BASE report.
Report is 37 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20521   +/-   ##
=========================================
  Coverage          ?   55.14%           
=========================================
  Files             ?      324           
  Lines             ?    55122           
  Branches          ?        0           
=========================================
  Hits              ?    30399           
  Misses            ?    22107           
  Partials          ?     2616           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaehanbyun
Copy link
Contributor Author

Hi @ishitasequeira,

After re-running the tests, I fixed the problematic part, and confirmed that the tests now pass successfully. PTAL. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

orphaned resource alerts
3 participants