-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add orphaned resource count metric #6391 #20521
base: master
Are you sure you want to change the base?
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jaehanbyun !! The overall change looks good!!
Hi @ishitasequeira, Auto merge did not execute properly. Could you please check? |
Looks like the tests failed. I will try rerunning the tests. |
Hello @ishitasequeira, Could you please rerun the tests when you have a moment? Let me know if you need anything else. Thank you! |
Signed-off-by: jaehanbyun <[email protected]>
Head branch was pushed to by a user without write access
3d14204
to
d4da596
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20521 +/- ##
=========================================
Coverage ? 55.14%
=========================================
Files ? 324
Lines ? 55122
Branches ? 0
=========================================
Hits ? 30399
Misses ? 22107
Partials ? 2616 ☔ View full report in Codecov by Sentry. |
Hi @ishitasequeira, After re-running the tests, I fixed the problematic part, and confirmed that the tests now pass successfully. PTAL. Thank you! |
Closes: #6391
Checklist:
What I have done:
For issue #6391, I have added a metric that indicates the count of orphaned resources for each application. This new metric is called
argocd_app_orphaned_resources_count{label...}
and tracks the number of orphaned resources per application.Metric Output: