Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prompting to confirm deletion of gpg public key #20539

Merged

Conversation

pasha-codefresh
Copy link
Member

It uses ability to configure prompts behavior inside configuration or flags. Default behavior is no promts, so we actually not affecting any existing behavior, but users can define promts to be enabled for their CLI
Details here:

#19528

  1. Default behavior

Снимок экрана 2024-10-26 в 00 38 14

  1. Prompts enabled

Снимок экрана 2024-10-26 в 00 38 33
Снимок экрана 2024-10-26 в 00 38 40

@pasha-codefresh pasha-codefresh requested a review from a team as a code owner October 25, 2024 21:41
Copy link

bunnyshell bot commented Oct 25, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Signed-off-by: pashakostohrys <[email protected]>
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good!!

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@a0b6943). Learn more about missing BASE report.
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/gpg.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20539   +/-   ##
=========================================
  Coverage          ?   55.19%           
=========================================
  Files             ?      324           
  Lines             ?    55088           
  Branches          ?        0           
=========================================
  Hits              ?    30408           
  Misses            ?    22070           
  Partials          ?     2610           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasha-codefresh pasha-codefresh merged commit 16e7517 into argoproj:master Oct 26, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants