Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Dex OIDC example #20545

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Conversation

preethi-sv
Copy link
Contributor

@preethi-sv preethi-sv commented Oct 26, 2024

There is a bug in the docs for using Dex with OIDC. type for using OIDC claim should be oidc instead of OIDC.

Note: When used as OIDC instead of oidc, following error would be seen in the dex-server pods.

error parse config file /tmp/dex.yaml: error unmarshaling JSON: unknown connector type "OIDC"

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
    • This is a small bug fix in docs and need not be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Type for using OIDC claim should be `oidc` instead of `OIDC`.

Signed-off-by: Preethi Sureshkumar <[email protected]>
@preethi-sv preethi-sv requested review from a team as code owners October 26, 2024 16:03
Copy link

bunnyshell bot commented Oct 26, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Signed-off-by: Preethi Sureshkumar <[email protected]>
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

@todaywasawesome todaywasawesome enabled auto-merge (squash) October 30, 2024 04:24
@todaywasawesome todaywasawesome merged commit d408909 into argoproj:master Oct 30, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants