feat: add prompting to confirm delete certificate #20547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pashakostohrys <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20547 +/- ##
=========================================
Coverage ? 55.18%
=========================================
Files ? 324
Lines ? 55101
Branches ? 0
=========================================
Hits ? 30409
Misses ? 22083
Partials ? 2609 ☔ View full report in Codecov by Sentry. |
cmd/argocd/commands/cert.go
Outdated
| } | ||
| } else { | ||
| fmt.Println("No certificates were removed (none matched the given patterns)") | ||
| fmt.Printf("The command to to remove all certificates for '%s' was cancelled.\n", hostNamePattern) |
There was a problem hiding this comment.
nit:
Suggested change
| fmt.Printf("The command to to remove all certificates for '%s' was cancelled.\n", hostNamePattern) | |
| fmt.Printf("The command to remove all certificates for '%s' was cancelled.\n", hostNamePattern) |
cmd/argocd/commands/cert.go
Outdated
| fmt.Printf("Removed cert for '%s' of type '%s' (subtype '%s')\n", cert.ServerName, cert.CertType, cert.CertSubType) | ||
| } | ||
| } else { | ||
| fmt.Println("No certificates were removed (none matched the given patterns)") |
There was a problem hiding this comment.
nit: patterns -> pattern
Signed-off-by: pashakostohrys <[email protected]>
ishitasequeira
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows for prompt behavior configuration through settings or flags. By default, prompts are disabled, ensuring no change to existing functionality. However, users can enable prompts for their CLI if desired.
Details here:
#19528