Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(diff): avoid cache miss in server-side diff #20605

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix(diff): avoid cache miss in server-side diff #20605

merged 1 commit into from
Oct 31, 2024

Conversation

crenshaw-dev
Copy link
Member

Follows up on #20424 because that PR didn't handle the inferred field.

@crenshaw-dev crenshaw-dev requested a review from a team as a code owner October 30, 2024 23:48
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 30, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

leoluz
leoluz approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev merged commit e861b55 into argoproj:master Oct 31, 2024
26 checks passed
@crenshaw-dev
Copy link
Member Author

/cherry-pick release-2.13

@crenshaw-dev
Copy link
Member Author

/cherry-pick release-2.12

@crenshaw-dev
Copy link
Member Author

/cherry-pick release-2.11

@crenshaw-dev crenshaw-dev deleted the diff-cache-mis-fix branch October 31, 2024 01:35
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Oct 31, 2024
@crenshaw-dev
fix(diff): avoid cache miss in server-side diff (#20605)
ae05b87 
Signed-off-by: Michael Crenshaw <[email protected]>
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Oct 31, 2024
@crenshaw-dev
fix(diff): avoid cache miss in server-side diff (#20605)
0f9ae29 
Signed-off-by: Michael Crenshaw <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Oct 31, 2024
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Oct 31, 2024
@crenshaw-dev
fix(diff): avoid cache miss in server-side diff (#20605)
a9f3511 
Signed-off-by: Michael Crenshaw <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Oct 31, 2024
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Oct 31, 2024
@crenshaw-dev
fix(diff): avoid cache miss in server-side diff (#20605)
8c86ffd 
Signed-off-by: Michael Crenshaw <[email protected]>
crenshaw-dev added a commit that referenced this pull request Oct 31, 2024
@gcp-cherry-pick-bot @crenshaw-dev
fix(diff): avoid cache miss in server-side diff (#20605) (#20607)
e7f9881 
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Oct 31, 2024
Merged
crenshaw-dev added a commit that referenced this pull request Oct 31, 2024
@gcp-cherry-pick-bot @crenshaw-dev
fix(diff): avoid cache miss in server-side diff (#20605) (#20608)
14aa95b 
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
crenshaw-dev added a commit that referenced this pull request Oct 31, 2024
@gcp-cherry-pick-bot @crenshaw-dev
fix(diff): avoid cache miss in server-side diff (#20605) (#20609)
e48878b 
Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crenshaw-dev @leoluz