Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add prompting to confirm project deletion #20612

Merged
merged 4 commits into from
Oct 31, 2024
Merged

feat: add prompting to confirm project deletion #20612

merged 4 commits into from
Oct 31, 2024

Conversation

pasha-codefresh
Copy link
Member

@pasha-codefresh pasha-codefresh commented Oct 31, 2024 •
edited
Loading

Related to: #19528

@pasha-codefresh pasha-codefresh requested a review from a team as a code owner October 31, 2024 10:11
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 31, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 55.18%. Comparing base (e861b55) to head (ac376ef).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/project.go 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #20612      +/-   ##
==========================================
+ Coverage   55.16%   55.18%   +0.02%     
==========================================
  Files         324      324              
  Lines       55139    55145       +6     
==========================================
+ Hits        30415    30432      +17     
+ Misses      22099    22092       -7     
+ Partials     2625     2621       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ishitasequeira
ishitasequeira approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishitasequeira ishitasequeira merged commit 83b1b6c into argoproj:master Oct 31, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pasha-codefresh @ishitasequeira