Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): accept HTTP/1.1 for backward compatibility #20639

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

agaudreault
Copy link
Member

@agaudreault agaudreault commented Nov 1, 2024

Some client such as curl will use http/1.1 by default and only supporting the http2 protocol is a breaking change for these clients. Also, the http2 is not supported in Argo currently for HTTPS as far as I can see, only for grpc.

We must support HTTP1.1 . Here is a quick recap of the NextProtos config
http1.1 + h2 => works
h2 + http1.1 => curl needs --http1.1 param && readiness are different depending if server is insecure or not => very annoying
h2 => curl/readiness wont work
http1.1 => grpc/UI wont work
nothing => we need to add an env var to disable this, which ends up doing the same as "http1.1 + h2"

Caused by #20579

Signed-off-by: Alexandre Gaudreault <[email protected]>
Copy link

bunnyshell bot commented Nov 1, 2024

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-jhbk7z.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-jhbk7z.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.14%. Comparing base (11267b9) to head (adb4536).

Files with missing lines Patch % Lines
server/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20639   +/-   ##
=======================================
  Coverage   55.13%   55.14%           
=======================================
  Files         324      324           
  Lines       55197    55197           
=======================================
+ Hits        30432    30437    +5     
+ Misses      22148    22137   -11     
- Partials     2617     2623    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault agaudreault marked this pull request as ready for review November 1, 2024 20:07
@agaudreault agaudreault requested a review from a team as a code owner November 1, 2024 20:07
server/server.go Outdated Show resolved Hide resolved
Co-authored-by: Michael Crenshaw <[email protected]>
Signed-off-by: Alexandre Gaudreault <[email protected]>
@agaudreault agaudreault enabled auto-merge (squash) November 1, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants