fix(server): accept HTTP/1.1 for backward compatibility #20639
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some client such as curl will use http/1.1 by default and only supporting the http2 protocol is a breaking change for these clients. Also, the http2 is not supported in Argo currently for HTTPS as far as I can see, only for grpc.
We must support HTTP1.1 . Here is a quick recap of the NextProtos config
http1.1 + h2 => works
h2 + http1.1 => curl needs --http1.1 param && readiness are different depending if server is insecure or not => very annoying
h2 => curl/readiness wont work
http1.1 => grpc/UI wont work
nothing => we need to add an env var to disable this, which ends up doing the same as "http1.1 + h2"
Caused by #20579